MAINT: align test_dispatcher s390x targets with _umath_tests_mtargets#24814
Merged
charris merged 2 commits intonumpy:maintenance/1.26.xfrom Nov 7, 2023
Merged
MAINT: align test_dispatcher s390x targets with _umath_tests_mtargets#24814charris merged 2 commits intonumpy:maintenance/1.26.xfrom
charris merged 2 commits intonumpy:maintenance/1.26.xfrom
Conversation
Member
|
The one test failure on TravisCI looks real, as noted on the original PR at #24772 (comment) |
Member
My bad, |
Member
Author
|
Thanks for the update Sayed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24772.
This updates https://github.com/numpy/numpy/blob/main/numpy/core/tests/test_cpu_dispatcher.py#L12 targets matching what is set at https://github.com/numpy/numpy/blob/main/numpy/core/meson.build#L688 (i.e. adding VE and VXE).
This was discovered when testing an s390x build with optimization on.