TST: Do not test for signalling NaNs not raising warnings#19477
Closed
seberg wants to merge 1 commit intonumpy:mainfrom
Closed
TST: Do not test for signalling NaNs not raising warnings#19477seberg wants to merge 1 commit intonumpy:mainfrom
seberg wants to merge 1 commit intonumpy:mainfrom
Conversation
This is technically even incorrect in IEEE, signalling NaNs should pretty much always give a warning. But overall, it seems unlikely NumPy should bother about it (we never create them after all). This is split off from numpygh-19476. Mainly, to check whether s390x is broken...
Member
Author
|
Nvm, I missed that the test was written in a way so that it would only be valid on little-endian machines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically even incorrect in IEEE, signalling NaNs should
pretty much always give a warning. But overall, it seems unlikely
NumPy should bother about it (we never create them after all).
This is split off from gh-19476. Mainly, to check whether s390x is
broken...