BUG: Add missing DECREF in new path

seberg · charris · commit fa5754e8c159 · 2021-06-19T07:32:57.000-06:00
Pretty, harmless reference count leak (the method is a singleton)
diff --git a/numpy/core/src/multiarray/convert_datatype.c b/numpy/core/src/multiarray/convert_datatype.c
@@ -476,6 +476,7 @@ PyArray_CheckCastSafety(NPY_CASTING casting,
 
     if (PyArray_MinCastSafety(castingimpl->casting, casting) == casting) {
         /* No need to check using `castingimpl.resolve_descriptors()` */
+        Py_DECREF(meth);
         return 1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -476,6 +476,7 @@ PyArray_CheckCastSafety(NPY_CASTING casting,`
`476`	`476`
`477`	`477`	`if (PyArray_MinCastSafety(castingimpl->casting, casting) == casting) {`
`478`	`478`	/* No need to check using `castingimpl.resolve_descriptors()` */
	`479`	`+ Py_DECREF(meth);`
`479`	`480`	`return 1;`
`480`	`481`	`}`
`481`	`482`