Use noremap to avoid problems with overridden built-ins#14
Merged
Conversation
If <c-o> is mapped to something else, for instance, this prevents the mappings from working correctly.
Owner
|
Ah, I see what you mean about your setup. I think if we instead defined an imap for |
Owner
|
What do you think about these changes? It resolves your issue on my setup. |
Contributor
Author
|
It works fine for me, yeah 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
<c-o>is mapped to something else, for instance, this prevents the mappings from working correctly. This happens to be the case in my config (mapped it to<c-x><c-o>for simpler completion, not that I use it much), so I hit the problem when trying the plugin out.Using
noremapthere works fine for me, and it shouldn't cause problems with<Plug>, according to the docs of:help noremap: