LUA_BUILD_AS_DLL needs to affect only the liblua target

drahosp · drahosp · commit 59da638d4f1f · 2012-10-02T17:49:02.000+02:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -40,9 +40,6 @@ if ( WIN32 AND NOT CYGWIN )
   # Windows systems
   option ( LUA_WIN "Windows specific build." ON )
   option ( LUA_BUILD_AS_DLL "Build Lua library as Dll." ${BUILD_SHARED_LIBS} )
-  if ( LUA_BUILD_AS_DLL )
-    add_definitions ( -DLUA_BUILD_AS_DLL )
-  endif ()
   
   # Paths (Double escapes ne  option ( LUA_BUILD_AS_DLL "Build Lua library as Dll." ON )eded)
   set ( LUA_DIRSEP "\\\\" )
@@ -125,6 +122,9 @@ endif ( )
 add_library ( liblua SHARED ${SRC_CORE} ${SRC_LIB} ${LUA_DLL_RC} ${LUA_DEF} )
 target_link_libraries ( liblua ${LIBS} )
 set_target_properties ( liblua PROPERTIES OUTPUT_NAME lua CLEAN_DIRECT_OUTPUT 1 )
+if ( LUA_BUILD_AS_DLL )
+  set_target_properties ( liblua PROPERTIES COMPILE_DEFINITIONS LUA_BUILD_AS_DLL )
+endif ()
 
 add_executable ( lua ${SRC_LUA} src/lua.rc )
 target_link_libraries ( lua liblua )
