Support for 2 legged OAuth plus minor clean ups and fixes#35
Closed
nikosd wants to merge 13 commits intonu7hatch:masterfrom
Closed
Support for 2 legged OAuth plus minor clean ups and fixes#35nikosd wants to merge 13 commits intonu7hatch:masterfrom
nikosd wants to merge 13 commits intonu7hatch:masterfrom
Conversation
added 13 commits
August 31, 2011 09:43
Owner
|
Sorry, i can't accept that bulk of whitespace changes etc... The main idea of patches is to not mix the changes, if you have something important there please send it in a separate pull request. Thx |
Contributor
|
This issue was moved to gmailgem/gmail#35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
Since the gmail_xoauth has support for 2 legged authentication I believe the gmail gem should support it too :)
I couldn't think of way to write actual integration tests but I added some mocked ones and have already tested it on live production code and it seems to be working ok.
Review it and let me know if you have any objections / ideas / etc...