Open
Conversation
|
I'm all for the change from 2 to 4 tabs. I think that the other rule is perhaps overly restrictive, because there are situations where declaring local variables inside of case conditions makes the code more readable. Perhaps we can modify the language to require curly braces around the block only when declaring branch-local variables, and otherwise not using them? |
Author
|
@justinbach If you're okay with starting to enforce the second case, then it's fine with me. My biggest issue is that we already have a ton of code in place not enforcing that rule (especially in WWW, with all of the reducers), and it's useless to have rules that we're not going to enforce ourselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.