fix: move all definitions to @npmcli/config package#6497
Conversation
1ad829d to
f9468c5
Compare
f9468c5 to
098c450
Compare
|
found 1 benchmarks with statistically significant performance improvements
timing results
|
bc5d054 to
f1c826a
Compare
|
@lukekarrys does this PR change the fundamental message of the package?
We're looking for the best approach to move from |
good catch! yes, with this change that statement is no longer true. we've found it is best to have all the config definitions live alongside the logic in i haven't taken a look at updating the docs yet, since i have a larger refactor in process that will contain a few breaking changes, and was updating the documentation in that branch. this PR is a stop-gap to implement the diff-heavy work of moving the config files, without changing anything about the implementation.
one of the goals of the next major version, will be to limit what is required to be passed in to |
f1c826a to
39cb7bb
Compare
07dd35e to
c9b7f8f
Compare
|
Hi @lukekarrys, Do you plan a new release with those changes? Cheers |
This builds on #6490 to avoid conflicts with the config changes there.Marking this as a draft until that lands, then this can be rebased if necessary and marked as ready for review.This is ready