feat: separate login/adduser, remove auth types#5550
Merged
lukekarrys merged 1 commit intolatestfrom Sep 21, 2022
Merged
Conversation
BREAKING CHANGE: This removes all `auth-type` configs except `web` and
`legacy`.
BREAKING CHANGE: Finally, `login` and `adduser` are now separate
commands that send different data to the registry.
BREAKING CHANGE: `auth-type` config values `web` and `legacy` only try
their respective methods, npm no longer tries them all and waits to see
which one doesn't fail.
The difference between `adduser` and `login` depends on the `auth-type`.
- `web`: the POST to `/-/v1/login` contains a `{ create: true }` value
in its payload for `adduser`
- `legacy` the `PUT` request to `/-/user/org.couchdb.user:${username}`
contains an `email` value in its payload for `adduser`.
wraithgar
force-pushed
the
gar/auth-strategies
branch
from
aaa2087 to
c860c61
Compare
Member
Author
|
Closes npm/statusboard#452 |
Collaborator
|
found 1 benchmarks with statistically significant performance regressions
timing results
|
lukekarrys
approved these changes
Sep 21, 2022
This was referenced Nov 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This removes all
auth-typeconfigs exceptwebandlegacy.BREAKING CHANGE: Finally,
loginandadduserare now separatecommands that send different data to the registry.
BREAKING CHANGE:
auth-typeconfig valueswebandlegacyonly trytheir respective methods, npm no longer tries them all and waits to see
which one doesn't fail.
The difference between
adduserandlogindepends on theauth-type.web: the POST to/-/v1/logincontains a{ create: true }valuein its payload for
adduserlegacythePUTrequest to/-/user/org.couchdb.user:${username}contains an
emailvalue in its payload foradduser.