fix(fund): open url for string shorthand#501
Closed
ruyadorno wants to merge 1 commit intonpm:latestfrom
Closed
Conversation
Trying to open url for a package that is using the string shorthand is currently broken using: `npm fund <pkg>` This commit fixes the issue and adds the missing unit and integration tests covering that usecase. Fixes npm#498
mikemimik
added
Release 6.x
This was referenced Dec 12, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
This was referenced Mar 10, 2020
This was referenced Mar 19, 2020
This was referenced Mar 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Trying to open url for a package that is using the string shorthand is currently broken using:
npm fund <pkg>✏️ Changes
This commit fixes the issue and adds the missing unit and integration tests covering that usecase.
🔗 References
npm fund <package>errors when "funding" is a string #498🔍 Testing
Manual testing:
In a folder with a given
package.json:{ "name": "foo", "version": "1.0.0", "funding": "http://example.com" }Running
npm fund .should open the funding url in default browser:✅ This change has unit test coverage
✅ This change has integration test coverage
🔥 Rollback
This can be reverted at any time