fix(did-you-mean): switch levenshtein libraries#3640
Merged
wraithgar merged 1 commit intorelease-nextfrom Aug 17, 2021
Merged
Conversation
Closed
wraithgar
force-pushed
the
gar/fastest-levenshtein
branch
from
d49029f to
eda148f
Compare
darcyclarke
added
semver:patch
nlf
approved these changes
Aug 17, 2021
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
straight forward swap, looks good
`leven` dropped support for node10 and we still currently have to support it. Moved to https://github.com/ka-weihe/fastest-levenshtein Originally discussed in #2403, but the did-you-mean lib moved quite a bit since then and there were conflicts so I made a new PR PR-URL: #3640 Credit: @wraithgar Close: #3640 Reviewed-by: @nlf
wraithgar
force-pushed
the
gar/fastest-levenshtein
branch
from
eda148f to
32e88c9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
levendropped support for node10 and we still currently have to supportit. Moved to https://github.com/ka-weihe/fastest-levenshtein
Originally discussed in #2403, but the
did-you-mean lib moved quite a bit since then and there were conflicts
so I made a new PR
References
Closes #2403