exclude NODE_EMBEDDER_MODULE_VERSION string (#23)

richardlau · web-flow · commit 3c31920c91d1 · 2023-10-16T16:22:50.000Z
When extracting the module version from `src/node_version.h`, ignore the line: #define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION This will pick up the default value from the header as the official Node.js builds do not define `NODE_EMBEDDER_MODULE_VERSION`. Fixes: #20 Refs: nodejs/node#49279
diff --git a/dist-indexer.js b/dist-indexer.js
@@ -325,7 +325,7 @@ function fetchModVersion (gitref, callback) {
       return callback(err)
     }
 
-    let m = rawData.match(/^#define NODE_MODULE_VERSION\s+([^\s]+)\s+.+$/m)
+    let m = rawData.match(/^#define NODE_MODULE_VERSION\s+((?!NODE_EMBEDDER_MODULE_VERSION)[^\s]+)\s+.+$/m)
     version = m && m[1]
 
     if (version) {

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ function fetchModVersion (gitref, callback) {`
`325`	`325`	`return callback(err)`
`326`	`326`	`}`
`327`	`327`
`328`		`- let m = rawData.match(/^#define NODE_MODULE_VERSION\s+([^\s]+)\s+.+$/m)`
	`328`	`+ let m = rawData.match(/^#define NODE_MODULE_VERSION\s+((?!NODE_EMBEDDER_MODULE_VERSION)[^\s]+)\s+.+$/m)`
`329`	`329`	`version = m && m[1]`
`330`	`330`
`331`	`331`	`if (version) {`