This repository was archived by the owner on Apr 22, 2023. It is now read-only.
src/node.cc: fix build error without OpenSSL support#25862
Closed
joerg-krause wants to merge 1 commit intonodejs:v0.10from
joerg-krause:fix-non-openssl-build
Closed
src/node.cc: fix build error without OpenSSL support#25862joerg-krause wants to merge 1 commit intonodejs:v0.10from joerg-krause:fix-non-openssl-build
joerg-krause wants to merge 1 commit intonodejs:v0.10from
joerg-krause:fix-non-openssl-build
Conversation
Signed-off-by: Jörg Krause <[email protected]>
This was referenced Aug 15, 2015
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 29, 2015
Signed-off-by: Jörg Krause <[email protected]> PR-URL: #25862 Reviewed-By: jasnell - James M Snell <[email protected]>
Member
|
Landed in 16ca077 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmit PR #8761 since the forked repo was closed by myself. This fixes the issue reported upstream: #8676
Commit d601c76 introduced a bug which includes
node_crypto.htwice. Once conditionally withHAVE_OPENSSLand once without it:Fix this by removing the unconditional header include of
node_crypto.hand add conditions for the OpenSSL related parts.