feat: add ncu-ci cigtm <jobid>#454
Merged
codebytere merged 9 commits intonodejs:masterfrom Jul 9, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
==========================================
+ Coverage 76.94% 77.35% +0.40%
==========================================
Files 21 21
Lines 1501 1572 +71
==========================================
+ Hits 1155 1216 +61
- Misses 346 356 +10
Continue to review full report at Codecov.
|
Member
|
Liking the current output ❤️ . These could be future/follow up enhancements to make comparisons easier:
|
Member
Author
|
@richardlau i updated it a bit to use a bespoke table, and also made json output a bit nicer! It's in the PR body in the details fold. I think (?) this is ready for review now 🚀 |
Member
|
@codebytere It looks like |
Member
Author
|
@richardlau fixed up and example output for json and markdown added to body! |
richardlau
approved these changes
Jul 7, 2020
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
LGTM thanks.
FYI GitHub checks are complaining about test coverage.
Member
Author
|
I'm planning on trying to cut a new release of ncu sometime soon and would love for this to make it in if one of y'all has time to PTAL :) |
mmarchini
approved these changes
Jul 9, 2020
This was referenced Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #352.
Adds
ncu-ci cigtm <jobid>.Ideally i'll end up adding functionality to compare two CITGM runs, e.g.
ncu-ci cigtm <job1id> <job2id>but i think it'll be easier to get this reviewed and merged if it's less massive.Todo:
Example Markdown Output
Example JSON Output
{ "source": "https://github.com/nodejs/node/pull/34093/", "upstream": "https://ci.nodejs.org/job/citgm-smoker/2400/", "passed": 594, "total": 848, "skipped": 233, "failed": 21, "debian9-64": { "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=debian9-64/2400/", "modules": [ { "name": "coffeescript-v2.5.1", "status": "FAILED" }, { "name": "through2-v4.0.2", "status": "FAILED" } ] }, "rhel7-s390x": { "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=rhel7-s390x/2400/", "modules": [ { "name": "through2-v4.0.2", "status": "FAILED" } ] }, "fedora-latest-x64": { "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/2400/", "modules": [ { "name": "coffeescript-v2.5.1", "status": "FAILED" }, { "name": "through2-v4.0.2", "status": "FAILED" } ] }, "ubuntu1604-64": { "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu1604-64/2400/", "modules": [ { "name": "coffeescript-v2.5.1", "status": "FAILED" }, { "name": "through2-v4.0.2", "status": "FAILED" } ] }, "osx1014": { "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=osx1014/2400/", "modules": [ { "name": "acorn-v7.3.1", "status": "FAILED" }, { "name": "coffeescript-v2.5.1", "status": "FAILED" }, { "name": "clinic-v6.0.2", "status": "FAILED" }, { "name": "ember-cli-v3.19.0", "status": "FAILED" }, { "name": "semver-v7.3.2", "status": "FAILED" }, { "name": "watchify-v3.11.1", "status": "FAILED" } ] }, "ubuntu1804-64": { "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu1804-64/2400/", "modules": [ { "name": "coffeescript-v2.5.1", "status": "FAILED" }, { "name": "through2-v4.0.2", "status": "FAILED" } ] }, "fedora-last-latest-x64": { "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-last-latest-x64/2400/", "modules": [ { "name": "coffeescript-v2.5.1", "status": "FAILED" }, { "name": "through2-v4.0.2", "status": "FAILED" } ] }, "centos7-ppcle": { "url": "https://ci.nodejs.org/job/citgm-smoker/nodes=centos7-ppcle/2400/", "modules": [ { "name": "coffeescript-v2.5.1", "status": "FAILED" }, { "name": "clinic-v6.0.2", "status": "FAILED" }, { "name": "torrent-stream-v1.2.0", "status": "FAILED" }, { "name": "through2-v4.0.2", "status": "FAILED" } ] } }Current output format: