Skip to content

tools: don't build node for doc build #9660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thefourtheye wants to merge 2 commits into from
Closed

tools: don't build node for doc build #9660

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71edf4
tools: don't build node for doc build
thefourtheye Nov 17, 2016
0a7e46e
error out if node not found
thefourtheye Nov 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: don't build node for doc build 
Building node binary is not necessary for doc builds.

Refer: #9436 (comment)
  • Loading branch information
@thefourtheye
thefourtheye committed Nov 17, 2016
commit b71edf4917f251c6763e2f841e00b3322ed76431
5 changes: 2 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,7 @@ apidoc_dirs = out/doc out/doc/api/ out/doc/api/assets

apiassets = $(subst api_assets,api/assets,$(addprefix out/,$(wildcard doc/api_assets/*)))

doc-only: $(apidocs_html) $(apidocs_json)
doc: $(NODE_EXE) doc-only
doc: $(apidocs_html) $(apidocs_json)

$(apidoc_dirs):
mkdir -p $@
Expand Down Expand Up @@ -750,5 +749,5 @@ endif
blog blogclean tar binary release-only bench-http-simple bench-idle \
bench-all bench bench-misc bench-array bench-buffer bench-net \
bench-http bench-fs bench-tls cctest run-ci test-v8 test-v8-intl \
test-v8-benchmarks test-v8-all v8 lint-ci bench-ci jslint-ci doc-only \
test-v8-benchmarks test-v8-all v8 lint-ci bench-ci jslint-ci \
$(TARBALL)-headers test-ci test-ci-native test-ci-js build-ci