Skip to content

Comments

doc: remove invalid padding from privateEncrypt#9611

Closed
JungMinu wants to merge 1 commit intonodejs:masterfrom
JungMinu:update-crypto.privateEncrypt
Closed

doc: remove invalid padding from privateEncrypt#9611
JungMinu wants to merge 1 commit intonodejs:masterfrom
JungMinu:update-crypto.privateEncrypt

Conversation

@JungMinu
Copy link
Member

@JungMinu JungMinu commented Nov 15, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fixes: #9609

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Nov 15, 2016
@JungMinu JungMinu self-assigned this Nov 15, 2016
@JungMinu JungMinu mentioned this pull request Nov 15, 2016
Closed
claudiorodriguez
claudiorodriguez approved these changes Nov 15, 2016
View reviewed changes
Copy link
Contributor

@claudiorodriguez claudiorodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sam-github
sam-github suggested changes Nov 15, 2016
View reviewed changes
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask that you remove the whitespace cleanups that are not relevant to this PR or its commit message?

I put a separate PR in for them: #9620

Also, could you rename the commit to doc: remove invalid padding from privateEncrypt

@sam-github sam-github mentioned this pull request Nov 15, 2016
Merged
2 tasks
@JungMinu JungMinu changed the title doc: update crypto.privateEncrypt() padding list doc: remove invalid padding from privateEncrypt Nov 16, 2016
@JungMinu
Copy link
Member Author

JungMinu commented Nov 16, 2016

@sam-github Done, PTAL again 😄

@JungMinu
Copy link
Member Author

JungMinu commented Nov 16, 2016

@mscdex PTAL 😄

@mscdex
Copy link
Contributor

mscdex commented Nov 16, 2016

LGTM

@silverwind
Copy link
Contributor

silverwind commented Nov 18, 2016

Thanks! Landed in be0ce60.

@silverwind silverwind closed this Nov 18, 2016
silverwind pushed a commit that referenced this pull request Nov 18, 2016
@JungMinu @silverwind
doc: remove invalid padding from privateEncrypt
be0ce60 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@JungMinu @addaleax
doc: remove invalid padding from privateEncrypt
c99fb1e 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@JungMinu @MylesBorins
doc: remove invalid padding from privateEncrypt
c0d44df 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@JungMinu @MylesBorins
doc: remove invalid padding from privateEncrypt
ff7d856 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@JungMinu @MylesBorins
doc: remove invalid padding from privateEncrypt
d4adb3d 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@JungMinu @MylesBorins
doc: remove invalid padding from privateEncrypt
ba37972 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
@jtousley jtousley mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+3 more reviewers

@sam-github sam-github sam-github approved these changes

@silverwind silverwind silverwind approved these changes

@claudiorodriguez claudiorodriguez claudiorodriguez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JungMinu JungMinu

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: crypto.privateEncrypt() padding list needs update

8 participants

@JungMinu @mscdex @silverwind @sam-github @jasnell @claudiorodriguez @MylesBorins @nodejs-github-bot