doc: fix typo e.g., => e.g. doc/dns.md#9563
Closed
dorako321 wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
dns
dorako321
changed the title
Member
|
please check your comment is followed commit guideline. |
silverwind
approved these changes
Nov 12, 2016
lpinca
approved these changes
Nov 12, 2016
shigeki
approved these changes
Nov 13, 2016
Contributor
|
@dorako321 Your git name in this commit is written in Japanese. It might be garbage characters in some terminals. Your screen name on your github profile is in English so do you mind to change your git name of this commit into English? |
Contributor
Author
|
@shigeki I fixed it. thanks. |
shigeki
pushed a commit
that referenced
this pull request
Nov 13, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Contributor
|
Thanks. Landed in 195989d. |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
fix typo e.g., => e.g.