Skip to content

tools: fix run-valgrind.py script #9520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 3 commits into from
Nov 15, 2016
Merged

tools: fix run-valgrind.py script #9520

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
043a98c
tools: copy run-valgrind.py to tools/
bnoordhuis Nov 8, 2016
e762ca0
tools: fix run-valgrind.py script
bnoordhuis Nov 8, 2016
a804627
tools: make run-valgrind.py useful
bnoordhuis Nov 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: fix run-valgrind.py script 
The script had a dependency on the copy of valgrind that is bundled
with V8 but that only gets checked out when doing a full depot_tools
checkout.  Use the system-provided valgrind.

PR-URL: #9520
Reviewed By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Nov 15, 2016
commit e762ca0060dcce3e047cacc7824ba07e0fb045f3
12 changes: 2 additions & 10 deletions tools/run-valgrind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,9 @@
import sys

V8_ROOT = path.dirname(path.dirname(path.abspath(__file__)))
MACHINE = 'linux_x64' if platform.machine() == 'x86_64' else 'linux_x86'
VALGRIND_ROOT = path.join(V8_ROOT, 'third_party', 'valgrind', MACHINE)
VALGRIND_BIN = path.join(VALGRIND_ROOT, 'bin', 'valgrind')
VALGRIND_LIB = path.join(VALGRIND_ROOT, 'lib', 'valgrind')

VALGRIND_ARGUMENTS = [
VALGRIND_BIN,
'valgrind',
'--error-exitcode=1',
'--leak-check=full',
'--smc-check=all',
Expand All @@ -65,11 +61,7 @@
command = VALGRIND_ARGUMENTS + [executable] + sys.argv[2:]

# Run valgrind.
process = subprocess.Popen(
command,
stderr=subprocess.PIPE,
env={'VALGRIND_LIB': VALGRIND_LIB}
)
process = subprocess.Popen(command, stderr=subprocess.PIPE)
code = process.wait();
errors = process.stderr.readlines();

Expand Down