tools: add lint rule to enforce timer arguments

Add a custom ESLint rule to require that setTimeout() and setInterval() get called with at least two arguments. This prevents omitting the duration or interval.
nodejs · Trott · Nov 4, 2016 · Nov 4, 2016 · Jan 6, 2017 · 8a4536d3035df430123c00f40c8d57e325e2b05b
commit 8a4536d3035df430123c00f40c8d57e325e2b05b
diff --git a/.eslintrc b/.eslintrc
@@ -128,6 +128,7 @@ rules:
   assert-fail-single-argument: 2
   assert-throws-arguments: [2, { requireTwo: false }]
   new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
+  timer-arguments: 2
 
 # Global scoped method and vars
 globals:

diff --git a/tools/eslint-rules/timer-arguments.js b/tools/eslint-rules/timer-arguments.js
@@ -0,0 +1,25 @@
+/**
+ * @fileoverview Require at least two arguments when calling setTimeout() or
+ * setInterval().
+ * @author Rich Trott
+ */
+'use strict';
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+function isTimer(name) {
+  return ['setTimeout', 'setInterval'].includes(name);
+}
+
+module.exports = function(context) {
+  return {
+    'CallExpression': function(node) {
+      const name = node.callee.name;
+      if (isTimer(name) && node.arguments.length < 2) {
+        context.report(node, `${name} must have at least 2 arguments`);
+      }
+    }
+  };
+};