Skip to content

http: remove stale timeout listeners #9440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlbohlmark wants to merge 10 commits into from
Closed

http: remove stale timeout listeners #9440

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
65790af
http: remove stale timeout listeners
Nov 1, 2016
5c37b4a
replace catch with unhandledRejection-listener
Nov 3, 2016
274cb28
use common.localhostIPv4
Nov 4, 2016
c32ee77
Increase timeout, output rejection reason
Nov 18, 2016
2c4ebae
use common.platformTimeout
Nov 18, 2016
fa6ec18
early exit on rejection
Nov 18, 2016
516ba6f
use EventEmitter#once
Nov 25, 2016
60ff0fb
test in callback-style
Nov 25, 2016
3039b1d
use socket.listeners, add common.mustCall
Nov 27, 2016
6cc3f0b
add common.mustCall
Nov 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replace catch with unhandledRejection-listener
  • Loading branch information
Karl Böhlmark committed Nov 3, 2016
commit 5c37b4a2ea6782a572f3612901f6f89394aef7dd
10 changes: 5 additions & 5 deletions test/parallel/test-http-client-timeout-option-listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
require('../common');
const common = require('../common');
const http = require('http');
const assert = require('assert');

Expand All @@ -18,6 +18,10 @@ const options = {
timeout: 10
};

process.on('unhandledRejection', function() {
common.fail('A promise rejection was unhandled');
});

server.listen(0, options.host, (e) => {
options.port = server.address().port;

Expand All @@ -27,10 +31,6 @@ server.listen(0, options.host, (e) => {
'Should be a single timeout listener on the socket');
server.close();
agent.destroy();
})
.catch((e) => {
console.log(e);
process.exit(1);
});
});

Expand Down