Skip to content

Removes call to net.Socket.resume #8679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ALJCepeda wants to merge 1 commit into from
Closed

Removes call to net.Socket.resume #8679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Removes call to net.Socket.resume 
`resume` is not necessary since `pause` is never called
  • Loading branch information
@ALJCepeda
ALJCepeda committed Sep 21, 2016
commit f376f67736fff90aefa9eba47b97f5ce75572ba9
4 changes: 0 additions & 4 deletions test/parallel/test-child-process-fork-net2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,6 @@ if (process.argv[2] === 'child') {
console.error('[m] CLIENT: close event');
disconnected += 1;
});
// XXX This resume() should be unnecessary.
// a stream high water mark should be enough to keep
// consuming the input.
client.resume();
}
});

Expand Down