Skip to content

doc: link onboarding to contributing guide #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

doc: link onboarding to contributing guide #8529

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05336d2
doc: link onboarding to contributing guide
Trott Sep 14, 2016
30b9f20
squash: wording change
Trott Sep 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: wording change
  • Loading branch information
@Trott
Trott committed Sep 14, 2016
commit 30b9f209c85c35d347ae4f4e1686cfcb83d5c714
2 changes: 1 addition & 1 deletion doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ Landing a PR
* Squash into logical commits if necessary.
* `./configure && make -j8 test` (`-j8` builds node in parallel with 8 threads. adjust to the number of cores (or processor-level threads) your processor has (or slightly more) for best results.)
* Amend the commit description.
* The commit message text must conform to the [guidelines for contributing](../CONTRIBUTING.md#step-3-commit).
* The commit message text must conform to the [commit message guidelines](../CONTRIBUTING.md#step-3-commit).
* Add required metadata:
* `PR-URL: <full-pr-url>`
* `Reviewed-By: <collaborator name> <collaborator email>`
Expand Down