Skip to content

Backport 2253 #8340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 7 commits into from
Closed

Backport 2253 #8340

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd55b79
build: add --enable-d8 configure option
bnoordhuis Jul 5, 2016
9308205
test: add --repeat option to tools/test.py
mhdawson May 11, 2016
a0a1de1
build: add node_module_version to config.gypi
saper Jul 20, 2016
3ecd06d
doc: improve server.listen() random port
phillipj Aug 8, 2016
4bfb247
test: exclude tests for AIX
mhdawson Aug 11, 2016
818f46d
test: test preloaded modules when using stdin or repl
bmeck Jul 27, 2015
b98656e
test: fix flaky test-preload
Trott May 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add --repeat option to tools/test.py 
Manual backport from master to 4.x stream, original
commit message follows.

I often want to run a test many times to see if a failure
can be recreated and I believe this is a common
use case.  We even have this job in the CI
https://ci.nodejs.org/job/node-stress-single-test/configure
but often you want to run it on a specific machine.

This patch adds the --repeat option so that
you can repeat the selected set of tests a
number of times. Given existing options
in test.py this will allow you to run
one or more tests for the number of
repeats specified. For example:

tools/test.py -j8 --repeat 1000 parallel/test-process-exec-argv

runs the test-process-exec-argv test 1000 times,
running 8 copies in parallel

tools/test.py --repeat 2

would run the entire test suite twice.

PR-URL: #6700
Reviewed-By: Ben Noorhduis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
Reviewed-By: joaocgreis - João Reis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
  • Loading branch information
@mhdawson
mhdawson authored and Myles Borins committed Aug 16, 2016
commit 9308205eaa858284e2b281f200ad3afd6ba659b0
13 changes: 9 additions & 4 deletions tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,8 +774,7 @@ def AddTestsToList(self, result, current_path, path, context, arch, mode):
tests = self.GetConfiguration(context).ListTests(current_path, path,
arch, mode)
for t in tests: t.variant_flags = v
result += tests

result += tests * context.repeat

def GetTestStatus(self, context, sections, defs):
self.GetConfiguration(context).GetTestStatus(sections, defs)
Expand Down Expand Up @@ -828,7 +827,8 @@ def GetTestStatus(self, context, sections, defs):
class Context(object):

def __init__(self, workspace, buildspace, verbose, vm, expect_fail,
timeout, processor, suppress_dialogs, store_unexpected_output):
timeout, processor, suppress_dialogs,
store_unexpected_output, repeat):
self.workspace = workspace
self.buildspace = buildspace
self.verbose = verbose
Expand All @@ -838,6 +838,7 @@ def __init__(self, workspace, buildspace, verbose, vm, expect_fail,
self.processor = processor
self.suppress_dialogs = suppress_dialogs
self.store_unexpected_output = store_unexpected_output
self.repeat = repeat

def GetVm(self, arch, mode):
if arch == 'none':
Expand Down Expand Up @@ -1369,6 +1370,9 @@ def BuildOptions():
default="")
result.add_option('--temp-dir',
help='Optional path to change directory used for tests', default=False)
result.add_option('--repeat',
help='Number of times to repeat given tests',
default=1, type="int")
return result


Expand Down Expand Up @@ -1533,7 +1537,8 @@ def Main():
options.timeout,
processor,
options.suppress_dialogs,
options.store_unexpected_output)
options.store_unexpected_output,
options.repeat)
# First build the required targets
if not options.no_build:
reqs = [ ]
Expand Down