Conversation
|
LGTM Upd: yes, with removing the duplicate entry under Collaborators as @addaleax noted. |
|
I think Myles should be moved from the Collaborators list to the CTC members list, LGTM with that (and if @thealphanerd is happy with this, of course 😄) And yep, congratulations! |
|
+1 to the nit from @addaleax ... otherwise LGTM |
|
thank you all so much. very honored to be included! On Wed, Aug 24, 2016, 9:03 PM James M Snell [email protected]
|
|
also, lgtm |
|
pretty certain this one doesn't need the 48 hours... landing |
|
|
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
Looks like this was re-landed in 2367e6c with a force push. |
|
yep... accidentally botched the first one... thanks for updating the pr |
PR-URL: nodejs#8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
7 participants
This was voted on the CTC meeting this week so this PR just needs review, @thealphanerd can you check pls?
Congrats btw!