build: add --enable-d8 configure option#7538
Conversation
bnoordhuis
added
build
|
LGTM with (normal) CI: https://ci.nodejs.org/job/node-test-commit/3973/ |
|
LGTM |
|
where does the binary land? is this something we might want to not publicise in |
|
I would vote for a silent, undocumented option. This is something I've
|
|
Lgtm
|
|
lgtm! |
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: nodejs#7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
@gibfahn I'd be alright with a HACKING.md or whatever you want to call it in doc/. |
|
@bnoordhuis lts? |
|
@thealphanerd yes this would be helpful in v4 |
|
this does not land cleanly on v4.x @bnoordhuis would you be willing to backport? |
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: nodejs#7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
6 participants
Add an option to the configure script for building d8. Useful for
testing V8 standalone.