Conversation
|
LGTM |
3 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
|
CI has some unrelated failures, LGTM. |
|
When applying this change, I've observed that sometimes this test fails on I don't know if it's bug or a limitation with |
|
@bnoordhuis @saghul ... |
|
@santigimeno I think that is an issue specific to |
|
I'm ok with landing this as long as it doesn't cause problems with the CI, otherwise maybe waiting for the workaround is the better choice. |
|
Workaround is stranger than I thought. Some unpredictable and/or non-intuitive stuff going on. Bummer. |
Test fails if tmp dir does not exist when the test is run. Add common.refreshTmpDir() so that doesn't happen. PR-URL: nodejs#7327 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in cdcfeb7 |
Test fails if tmp dir does not exist when the test is run. Add common.refreshTmpDir() so that doesn't happen. PR-URL: #7327 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Test fails if tmp dir does not exist when the test is run. Add common.refreshTmpDir() so that doesn't happen. PR-URL: #7327 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
@Trott this doesn't land cleanly. Totally up for a backport though |
|
@thealphanerd The file this PR modifies was added in a semver-major PR, so it shouldn't land on LTS. |
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test fs
Description of change
Test fails if tmp dir does not exist when the test is run. Add
common.refreshTmpDir()so that doesn't happen.