Skip to content

debugger: remove obsolete setTimeout #7154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

debugger: remove obsolete setTimeout #7154

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
909009f
debugger: remove obsolete setTimeout
Trott Jun 4, 2016
a0d60c4
squash: try setImmediate
Trott Jun 5, 2016
3406e1b
squash: self -> this
Trott Jun 6, 2016
2bda6c1
squash: remove unneeded resume()
Trott Jun 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
debugger: remove obsolete setTimeout 
Remove obsolete `setTimeout()` introduced in 3148f14. The fix for the
problem is in b266074. (For the record, I mostly don't know what I'm
talking about here but am summarizing from an IRC #node-dev conversation
with @indutny on 04-Jun-2016.)
  • Loading branch information
@Trott
Trott committed Jun 6, 2016
commit 909009fbd23e7399a26abc789173b9b6608e696e
10 changes: 3 additions & 7 deletions lib/_debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,13 +829,9 @@ function Interface(stdin, stdout, args) {
// Run script automatically
this.pause();

// XXX Need to figure out why we need this delay
setTimeout(function() {

self.run(function() {
self.resume();
});
}, 10);
self.run(function() {
self.resume();
});
}


Expand Down