Skip to content

test: fix flaky test-preload #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: fix flaky test-preload #6728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-preload 
Use `close` event rather than `exit` event to make sure all output has
been received before checking assertions.

Fixes: #6722
  • Loading branch information
@Trott
Trott committed May 13, 2016
commit e614e65de2d7146b76c12c7111a89fdccdb4b759
4 changes: 2 additions & 2 deletions test/parallel/test-preload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ var stdinStdout = '';
stdinProc.stdout.on('data', function(d) {
stdinStdout += d;
});
stdinProc.on('exit', function(code) {
stdinProc.on('close', function(code) {
assert.equal(code, 0);
assert.equal(stdinStdout, 'A\nhello\n');
});
Expand All @@ -97,7 +97,7 @@ var replStdout = '';
replProc.stdout.on('data', function(d) {
replStdout += d;
});
replProc.on('exit', function(code) {
replProc.on('close', function(code) {
assert.equal(code, 0);
const output = [
'A',
Expand Down