Skip to content

tools: fix tools/doc/addon-verify.js regression (and more) #6652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 4 commits into from
May 10, 2016
Merged

tools: fix tools/doc/addon-verify.js regression (and more) #6652

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f644368
test: build addons with V8_DEPRECATION_WARNINGS=1
bnoordhuis May 9, 2016
2c75a6b
doc: fix deprecation warnings in addon examples
bnoordhuis May 9, 2016
0ea4855
build,test: fix build-addons dependency chain
bnoordhuis May 9, 2016
4f925dd
tools: fix tools/doc/addon-verify.js regression
addaleax May 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tools: fix tools/doc/addon-verify.js regression 
Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
@addaleax @bnoordhuis
addaleax authored and bnoordhuis committed May 10, 2016
commit 4f925dd1844f104e5a4e94ffc86783afcabeed82
2 changes: 1 addition & 1 deletion tools/doc/addon-verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const verifyDir = path.resolve(rootDir, 'test', 'addons');

const contents = fs.readFileSync(doc).toString();

const tokens = marked.lexer(contents, {});
const tokens = marked.lexer(contents);
let files = null;
let id = 0;

Expand Down