Skip to content

test: move assert to improve clarity #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: move assert to improve clarity #6428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: move assert to improve clarity 
A test is run, and then the relevant assertion is put after a different
test. Place the assertion near the relevant thing it is testing for
clarity.
  • Loading branch information
@Trott
Trott committed Apr 27, 2016
commit 0e05d3dccd095fd6afa6caa5f88d3ebdbb09373e
3 changes: 2 additions & 1 deletion test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,12 +394,13 @@ try {
} catch (e) {
gotError = true;
}
assert.ok(gotError);


// GH-7178. Ensure reflexivity of deepEqual with `arguments` objects.
var args = (function() { return arguments; })();
a.throws(makeBlock(a.deepEqual, [], args));
a.throws(makeBlock(a.deepEqual, args, []));
assert.ok(gotError);


var circular = {y: 1};
Expand Down