doc: fix crypto.sign and crypto.verify accepted types#63268
Open
Anshikakalpana wants to merge 1 commit into
Open
doc: fix crypto.sign and crypto.verify accepted types#63268Anshikakalpana wants to merge 1 commit into
Anshikakalpana wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
Signed-off-by: anshikakalpana <[email protected]>
Anshikakalpana
force-pushed
the
crypto-sign-verify-doc-types
branch
from
55ff922 to
6ebf424
Compare
Member
|
I would rather we do a single sweep PR that both ensures alignment, ensures coverage, and updates docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the documented accepted parameter types for
crypto.sign()andcrypto.verify()to match the current runtime behavior.Runtime testing confirmed that:
crypto.sign()acceptsArrayBuffer,SharedArrayBuffer, andstringfordatacrypto.verify()acceptsstringfordatacrypto.verify()rejectsArrayBufferandSharedArrayBufferfor bothdataandsignatureThe existing v15.0.0 changelog entry for
crypto.verify()mentionsArrayBuffersupport fordataandsignature, but current runtime behavior does not reflect that. A follow-up PR can address the runtime inconsistency inverifyOneShot().Fixes: #62903