http2: fix stream error reporting & 'finish' in the compat API

Previously, stream errors were completely swallowed and never exposed. With this change, they're exposed only if there is a listener for them - this is the exact same pattern used in HTTP/1 itself, so hopefully a good fit for the compat API! This also changes the compat API to only report 'finish' when the writable has actually finished - previously all closes were reporting with finish, even when the writable was aborted part way through.
nodejs · pimterry · May 7, 2026 · May 11, 2026 · May 12, 2026 · May 12, 2026
commit 69322256974a245a0aaef3a5a5c253648af3ed74
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -158,11 +158,11 @@ function onStreamEnd() {
 }
 
 function onStreamError(error) {
-  // This is purposefully left blank
-  //
-  // errors in compatibility mode are
-  // not forwarded to the request
-  // and response objects.
+  // Mirror HTTP/1's IncomingMessage._destroy: forward 'error' to req
+  // only when a listener is attached.
+  const request = this[kRequest];
+  if (request !== undefined && request.listenerCount('error') > 0)
+    request.emit('error', error);
 }
 
 function onRequestPause() {
@@ -460,7 +460,9 @@ function onStreamCloseResponse() {
   this.removeListener('wantTrailers', onStreamTrailersReady);
   this[kResponse] = undefined;
 
-  res.emit('finish');
+  // Only emit 'finish' when the underlying writable actually finished
+  if (this.writableFinished)
+    res.emit('finish');
   res.emit('close');
 }
 

diff --git a/test/parallel/test-http2-compat-errors.js b/test/parallel/test-http2-compat-errors.js
@@ -3,16 +3,20 @@
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
+const assert = require('assert');
 const h2 = require('http2');
 
-// Errors should not be reported both in Http2ServerRequest
-// and Http2ServerResponse
+// Errors on the underlying stream surface on Http2ServerRequest
 
 let expected = null;
 
 const server = h2.createServer(common.mustCall(function(req, res) {
-  res.stream.on('error', common.mustCall());
-  req.on('error', common.mustNotCall());
+  res.stream.on('error', common.mustCall((err) => {
+    assert.strictEqual(err, expected);
+  }));
+  req.on('error', common.mustCall((err) => {
+    assert.strictEqual(err, expected);
+  }));
   res.on('error', common.mustNotCall());
   req.on('aborted', common.mustCall());
   res.on('aborted', common.mustNotCall());

diff --git a/test/parallel/test-http2-compat-serverresponse-destroy.js b/test/parallel/test-http2-compat-serverresponse-destroy.js
@@ -16,10 +16,13 @@ const errors = [
 let nextError;
 
 const server = http2.createServer(common.mustCall((req, res) => {
-  req.on('error', common.mustNotCall());
+  if (req.url !== '/')
+    req.on('error', common.mustCall());
+  else
+    req.on('error', common.mustNotCall());
   res.on('error', common.mustNotCall());
 
-  res.on('finish', common.mustCall(() => {
+  res.on('close', common.mustCall(() => {
     res.destroy(nextError);
     process.nextTick(() => {
       res.destroy(nextError);

diff --git a/test/parallel/test-http2-compat-serverresponse-headers-after-destroy.js b/test/parallel/test-http2-compat-serverresponse-headers-after-destroy.js
@@ -13,7 +13,7 @@ const server = h2.createServer();
 server.listen(0, common.mustCall(function() {
   const port = server.address().port;
   server.once('request', common.mustCall(function(request, response) {
-    response.on('finish', common.mustCall(() => {
+    response.on('close', common.mustCall(() => {
       assert.strictEqual(response.headersSent, false);
       response.setHeader('test', 'value');
       response.removeHeader('test', 'value');

diff --git a/test/parallel/test-http2-compat-socket.js b/test/parallel/test-http2-compat-socket.js
@@ -51,7 +51,7 @@ server.on('request', common.mustCall(function(request, response) {
     assert.strictEqual(request.socket.readable, false);
     response.socket.destroy();
   }));
-  response.on('finish', common.mustCall(() => {
+  response.on('close', common.mustCall(() => {
     assert.ok(request.socket);
     assert.strictEqual(response.socket, undefined);
     assert.ok(request.socket.destroyed);

diff --git a/test/parallel/test-http2-many-writes-and-destroy.js b/test/parallel/test-http2-many-writes-and-destroy.js
@@ -7,6 +7,9 @@ const http2 = require('http2');
 
 {
   const server = http2.createServer((req, res) => {
+    // Peer destroys mid-stream, so we see errors here:
+    req.on('error', () => {});
+    res.on('error', () => {});
     req.pipe(res);
   });
 

diff --git a/test/parallel/test-http2-server-rst-stream.js b/test/parallel/test-http2-server-rst-stream.js
@@ -20,7 +20,6 @@ const {
 // (NO_ERROR/CANCEL) yield ERR_HTTP2_STREAM_ABORTED, other codes yield
 // ERR_HTTP2_STREAM_ERROR.
 const tests = [
-  [NGHTTP2_NO_ERROR, 'ERR_HTTP2_STREAM_ABORTED'],
   [NGHTTP2_NO_ERROR, 'ERR_HTTP2_STREAM_ABORTED'],
   [NGHTTP2_PROTOCOL_ERROR, 'ERR_HTTP2_STREAM_ERROR'],
   [NGHTTP2_CANCEL, 'ERR_HTTP2_STREAM_ABORTED'],