deps: update libuv to 1.52.1 by nodejs-github-bot · Pull Request #61829 · nodejs/node

nodejs-github-bot · 2026-02-15T00:52:06Z

This is an automated update of libuv to 1.52.1.

nodejs-github-bot · 2026-02-15T00:52:11Z

Review requested:

@nodejs/security-wg

github-actions · 2026-02-15T09:02:44Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 404 Not Found

https://github.com/nodejs/node/actions/runs/22032932485

nodejs-github-bot · 2026-02-18T14:22:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71354/

aduh95 · 2026-02-18T16:53:58Z

There seems to be a related failure on Windows:

stack: |-
  node:internal/assert/utils:146
    throw error;
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + 'write EPIPE'
  - 'write EBADF'
            ^

      at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-net-socket-write-after-close.js:15:16)
      at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:507:15)
      at Socket.emit (node:events:508:20)
      at emitErrorNT (node:internal/streams/destroy:170:8)
      at emitErrorCloseNT (node:internal/streams/destroy:129:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 'write EPIPE',
    expected: 'write EBADF',
    operator: 'strictEqual',
    diff: 'simple'
  }

  Node.js v26.0.0-pre

StefanStojanovic · 2026-02-19T13:58:31Z

I've taken a look at this. First of all, both native and JS tests (some other than the one mentioned in a previous comment) failed, so I reran the 2 jobs (native, JS), and the only failure left is the one from parallel.test-net-socket-write-after-close.

The reason for the failure seems to be the change from this PR. I do not know how the others feel, but for me personally, changing the expected behavior to a new error doesn't seem like a big issue and I'd go with that approach. Of course, I leave the option that there is something that would not allow this that I'm not aware of, so if there is, please let me know.

StefanStojanovic · 2026-03-02T14:54:43Z

Hey all, just wanted to ping here again about the Windows test failure and my suggestion to fix it - changing the error we expect in the test. If there are some objections to that approach, please let me know. Otherwise, I'll push the change to the test on Thursday/Friday this week.

codecov · 2026-03-09T10:52:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (3725bd2) to head (3622960).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61829   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         676      676           
  Lines      206543   206546    +3     
  Branches    39547    39541    -6     
=======================================
+ Hits       185184   185188    +4     
- Misses      13480    13493   +13     
+ Partials     7879     7865   -14

see 54 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 · 2026-03-10T12:27:49Z

@StefanStojanovic looks like your change breaks every other platforms though

StefanStojanovic · 2026-03-10T14:00:11Z

@StefanStojanovic looks like your change breaks every other platforms though

Well, at least now it's no longer my problem, Windows works well... xD Just kidding, will put a isWindows check in that test

nodejs-github-bot · 2026-03-15T23:46:55Z

Landed in 5bebd7e

PR-URL: #61829 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

PR-URL: nodejs#61829 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

PR-URL: #61829 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <[email protected]>

libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 90d1009)

* chore: bump node in DEPS to v24.16.0 * fix(patch): adapt GetIsolate removal for network_agent.cc refactor Upstream moved the static Object* helpers out of network_agent.cc into the new src/inspector/inspector_object_utils.{h,cc} and converted the existing methods to NetworkAgent member functions. Update the patch so the deprecated v8::Context::GetIsolate() removal applies to the new member methods that obtain the isolate via env_->isolate(). Ref: nodejs/node#61139 Co-Authored-By: Claude <[email protected]> * chore: remove upstreamed patch Node.js restored fs patchability in the ESM loader upstream, making the fix_lazyload_fs_in_esm_loaders_to_apply_asar_patches.patch obsolete (the patch's exact change is now in lib/internal/modules/ esm/{load,resolve,translators}.js). Ref: nodejs/node#62835 Co-Authored-By: Claude <[email protected]> * chore: update patches (trivial only) Co-Authored-By: Claude <[email protected]> * fix(patch): re-add experimental_fetch member after upstream cleanup Upstream removed the experimental_fetch field from EnvironmentOptions, but Electron's patch still registers --experimental-fetch as a CLI option bound to that field. Re-add the member so the option compiles. Ref: nodejs/node#62759 Co-Authored-By: Claude <[email protected]> * fix(patch): cast const away when freeing uv_cpu_info_t.model libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <[email protected]> * fix(patch): silence sign-compare warning in sessionVarintGetSafe Cast int nBuf to size_t when comparing with sizeof(aCopy) so the bundled sqlite3 amalgamation compiles under -Werror,-Wsign-compare. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> * test: move root package.json aside in node spec runner third_party/electron_node lives under Chromium's src/, whose package.json ("type": "module") is always an ancestor of the Node.js test tree. Upstream assumes no package.json sits above the tests, so that ancestor changes how test files and fixtures resolve their module type: it disables module-syntax detection (breaking test-compile-cache-typescript-esm) and emits MODULE_TYPELESS_PACKAGE_JSON warnings that break tests asserting clean stderr (test-esm-detect-ambiguous, test-esm-import-meta-main-eval, test-output-coverage-with-mock). Move src/package.json aside for the duration of the run so the environment matches upstream exactly, then restore it. The original is kept in a sibling backup file so an interrupted/killed run self-heals on the next invocation rather than leaving src/package.json missing. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> * chore: regenerate filenames.auto.gni for v24.16.0 headers New inspector/node headers added in Node.js v24.16.0 were missing from the auto-generated source list. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> * fix(patch): mark test-macos-app-sandbox as flaky The test copies the Electron binary into a standalone .app bundle and code-signs it; under parallel suite runs this races with dyld resolving the Electron Framework rpath and intermittently aborts (SIGABRT). It passes reliably when run alone. Mark it flaky so flakes don't fail CI. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> * test: disable test-tls-set-default-ca-certificates-extra-override setDefaultCACertificates() round-trips the default CA set through BoringSSL's X509_STORE, which dedups a duplicate-subject root (DigiCert Global Root CA) that OpenSSL keeps. The set therefore loses one cert on re-add (149 -> 148), so the test's assertEqualCerts round-trip check fails under Electron's BoringSSL. The sibling -recovery test is disabled for the same reason. Ref: nodejs/node#58822 Co-Authored-By: Claude <[email protected]> * fix(patch): mark test-runner watch tests as flaky test-run-watch-repeatedly, test-run-watch-run-duration and test-run-watch-without-file race under parallel suite load: the watcher fires an extra re-run before the assertion, so the expected single-run output ("tests 1") arrives with accumulated subtests. All three pass in isolation. Ref: nodejs/node#44898 Co-Authored-By: Claude <[email protected]> * chore: update patches * chore(patches): update libuv const-cast patch management Combine the Windows libuv cpu_info const-cast update into the existing chore_cast_const_away_when_freeing_uv_cpu_info_t_model.patch and keep a single patch-management commit for the final exported patch series. Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]>

libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 90d1009)

libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 90d1009) (cherry picked from commit 07827c6)

* chore: bump node in DEPS to v24.16.0 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * fix(patch): adapt GetIsolate removal for network_agent.cc refactor Upstream moved the static Object* helpers out of network_agent.cc into the new src/inspector/inspector_object_utils.{h,cc} and converted the existing methods to NetworkAgent member functions. Update the patch so the deprecated v8::Context::GetIsolate() removal applies to the new member methods that obtain the isolate via env_->isolate(). Ref: nodejs/node#61139 Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * chore: remove upstreamed patch Node.js restored fs patchability in the ESM loader upstream, making the fix_lazyload_fs_in_esm_loaders_to_apply_asar_patches.patch obsolete (the patch's exact change is now in lib/internal/modules/ esm/{load,resolve,translators}.js). Ref: nodejs/node#62835 Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * chore: update patches (trivial only) Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * fix(patch): re-add experimental_fetch member after upstream cleanup Upstream removed the experimental_fetch field from EnvironmentOptions, but Electron's patch still registers --experimental-fetch as a CLI option bound to that field. Re-add the member so the option compiles. Ref: nodejs/node#62759 Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * fix(patch): cast const away when freeing uv_cpu_info_t.model libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * fix(patch): silence sign-compare warning in sessionVarintGetSafe Cast int nBuf to size_t when comparing with sizeof(aCopy) so the bundled sqlite3 amalgamation compiles under -Werror,-Wsign-compare. Ref: nodejs/node#62699 Co-Authored-By: Claude <[email protected]> * test: move root package.json aside in node spec runner third_party/electron_node lives under Chromium's src/, whose package.json ("type": "module") is always an ancestor of the Node.js test tree. Upstream assumes no package.json sits above the tests, so that ancestor changes how test files and fixtures resolve their module type: it disables module-syntax detection (breaking test-compile-cache-typescript-esm) and emits MODULE_TYPELESS_PACKAGE_JSON warnings that break tests asserting clean stderr (test-esm-detect-ambiguous, test-esm-import-meta-main-eval, test-output-coverage-with-mock). Move src/package.json aside for the duration of the run so the environment matches upstream exactly, then restore it. The original is kept in a sibling backup file so an interrupted/killed run self-heals on the next invocation rather than leaving src/package.json missing. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * chore: regenerate filenames.auto.gni for v24.16.0 headers New inspector/node headers added in Node.js v24.16.0 were missing from the auto-generated source list. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * fix(patch): mark test-macos-app-sandbox as flaky The test copies the Electron binary into a standalone .app bundle and code-signs it; under parallel suite runs this races with dyld resolving the Electron Framework rpath and intermittently aborts (SIGABRT). It passes reliably when run alone. Mark it flaky so flakes don't fail CI. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * test: disable test-tls-set-default-ca-certificates-extra-override setDefaultCACertificates() round-trips the default CA set through BoringSSL's X509_STORE, which dedups a duplicate-subject root (DigiCert Global Root CA) that OpenSSL keeps. The set therefore loses one cert on re-add (149 -> 148), so the test's assertEqualCerts round-trip check fails under Electron's BoringSSL. The sibling -recovery test is disabled for the same reason. Ref: nodejs/node#58822 Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * fix(patch): mark test-runner watch tests as flaky test-run-watch-repeatedly, test-run-watch-run-duration and test-run-watch-without-file race under parallel suite load: the watcher fires an extra re-run before the assertion, so the expected single-run output ("tests 1") arrives with accumulated subtests. All three pass in isolation. Ref: nodejs/node#44898 Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> * chore: update patches Co-authored-by: John Kleinschmidt <[email protected]> * chore(patches): update libuv const-cast patch management Combine the Windows libuv cpu_info const-cast update into the existing chore_cast_const_away_when_freeing_uv_cpu_info_t_model.patch and keep a single patch-management commit for the final exported patch series. Co-Authored-By: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]>

* chore: bump node in DEPS to v24.16.0 * chore: remove upstreamed patch Node.js restored fs patchability in the ESM loader upstream, making the fix_lazyload_fs_in_esm_loaders_to_apply_asar_patches.patch obsolete (the patch's exact change is now in lib/internal/modules/ esm/{load,resolve,translators}.js). Ref: nodejs/node#62835 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 72638db) * fix(patch): re-add experimental_fetch member after upstream cleanup Upstream removed the experimental_fetch field from EnvironmentOptions, but Electron's patch still registers --experimental-fetch as a CLI option bound to that field. Re-add the member so the option compiles. Ref: nodejs/node#62759 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 6fd9370) * fix(patch): cast const away when freeing uv_cpu_info_t.model libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 90d1009) * fix(patch): silence sign-compare warning in sessionVarintGetSafe Cast int nBuf to size_t when comparing with sizeof(aCopy) so the bundled sqlite3 amalgamation compiles under -Werror,-Wsign-compare. Ref: nodejs/node#62699 Co-Authored-By: Claude <[email protected]> * test: move root package.json aside in node spec runner third_party/electron_node lives under Chromium's src/, whose package.json ("type": "module") is always an ancestor of the Node.js test tree. Upstream assumes no package.json sits above the tests, so that ancestor changes how test files and fixtures resolve their module type: it disables module-syntax detection (breaking test-compile-cache-typescript-esm) and emits MODULE_TYPELESS_PACKAGE_JSON warnings that break tests asserting clean stderr (test-esm-detect-ambiguous, test-esm-import-meta-main-eval, test-output-coverage-with-mock). Move src/package.json aside for the duration of the run so the environment matches upstream exactly, then restore it. The original is kept in a sibling backup file so an interrupted/killed run self-heals on the next invocation rather than leaving src/package.json missing. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> (cherry picked from commit 29abd0c) * fix(patch): mark test-macos-app-sandbox as flaky The test copies the Electron binary into a standalone .app bundle and code-signs it; under parallel suite runs this races with dyld resolving the Electron Framework rpath and intermittently aborts (SIGABRT). It passes reliably when run alone. Mark it flaky so flakes don't fail CI. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> (cherry picked from commit 3853529) * test: disable test-tls-set-default-ca-certificates-extra-override setDefaultCACertificates() round-trips the default CA set through BoringSSL's X509_STORE, which dedups a duplicate-subject root (DigiCert Global Root CA) that OpenSSL keeps. The set therefore loses one cert on re-add (149 -> 148), so the test's assertEqualCerts round-trip check fails under Electron's BoringSSL. The sibling -recovery test is disabled for the same reason. Ref: nodejs/node#58822 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 3dbc596) * fix(patch): mark test-runner watch tests as flaky test-run-watch-repeatedly, test-run-watch-run-duration and test-run-watch-without-file race under parallel suite load: the watcher fires an extra re-run before the assertion, so the expected single-run output ("tests 1") arrives with accumulated subtests. All three pass in isolation. Ref: nodejs/node#44898 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 0f9c327) * chore(patches): update libuv const-cast patch management Combine the Windows libuv cpu_info const-cast update into the existing chore_cast_const_away_when_freeing_uv_cpu_info_t_model.patch and keep a single patch-management commit for the final exported patch series. Co-Authored-By: Claude <[email protected]> (cherry picked from commit c590614) * fix(patch): add UV_LOOP_INTERRUPT_ON_IO_CHANGE option Ref: libuv/libuv#3308 Co-Authored-By: Claude <[email protected]> * chore: update patches (trivial only) Co-Authored-By: Claude <[email protected]> * chore: update patches Co-Authored-By: Claude <[email protected]> * fix(patch): adapt GetIsolate removal for the inspector NetworkAgent Adapts api_remove_deprecated_getisolate.patch for the inspector NetworkAgent: adapt the GetIsolate removal to the NetworkAgent member helpers, qualify the v8 Maybe helpers in network_agent, and drop duplicate inspector helper definitions. Ref: nodejs/node#62162 Co-Authored-By: Claude Opus 4.7 <[email protected]> * fix(patch): guard vm contextual-store strict assertion for Chromium's V8 test-vm-global-contextual-store was added upstream in nodejs/node#62571. It asserts that an undeclared strict-mode contextual store (`"use strict"; z = 42`) throws a ReferenceError. Chromium's V8 removed v8::PropertyCallbackInfo<T>::This(), so Electron's contextify setter cannot distinguish a contextual store from an explicit `globalThis.x = v` store; it keeps the original behavior (writing to the sandbox) so explicit global stores in vm modules keep working (test-vm-module-referrer-realm). Guard the strict-mode ReferenceError assertion in the new test under Electron. Ref: nodejs/node#62571 Ref: nodejs/node#60616 Co-Authored-By: Claude Opus 4.8 <[email protected]> --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Claude <[email protected]>

* chore: bump node in DEPS to v24.16.0 * chore: remove upstreamed patch Node.js restored fs patchability in the ESM loader upstream, making the fix_lazyload_fs_in_esm_loaders_to_apply_asar_patches.patch obsolete (the patch's exact change is now in lib/internal/modules/ esm/{load,resolve,translators}.js). Ref: nodejs/node#62835 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 72638db) (cherry picked from commit 0409547) * fix(patch): re-add experimental_fetch member after upstream cleanup Upstream removed the experimental_fetch field from EnvironmentOptions, but Electron's patch still registers --experimental-fetch as a CLI option bound to that field. Re-add the member so the option compiles. Ref: nodejs/node#62759 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 6fd9370) (cherry picked from commit 46b28d2) * fix(patch): cast const away when freeing uv_cpu_info_t.model libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 90d1009) (cherry picked from commit 07827c6) * fix(patch): silence sign-compare warning in sessionVarintGetSafe Cast int nBuf to size_t when comparing with sizeof(aCopy) so the bundled sqlite3 amalgamation compiles under -Werror,-Wsign-compare. Ref: nodejs/node#62699 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 379d109) * test: move root package.json aside in node spec runner third_party/electron_node lives under Chromium's src/, whose package.json ("type": "module") is always an ancestor of the Node.js test tree. Upstream assumes no package.json sits above the tests, so that ancestor changes how test files and fixtures resolve their module type: it disables module-syntax detection (breaking test-compile-cache-typescript-esm) and emits MODULE_TYPELESS_PACKAGE_JSON warnings that break tests asserting clean stderr (test-esm-detect-ambiguous, test-esm-import-meta-main-eval, test-output-coverage-with-mock). Move src/package.json aside for the duration of the run so the environment matches upstream exactly, then restore it. The original is kept in a sibling backup file so an interrupted/killed run self-heals on the next invocation rather than leaving src/package.json missing. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> (cherry picked from commit 29abd0c) (cherry picked from commit 3190c99) * fix(patch): mark test-macos-app-sandbox as flaky The test copies the Electron binary into a standalone .app bundle and code-signs it; under parallel suite runs this races with dyld resolving the Electron Framework rpath and intermittently aborts (SIGABRT). It passes reliably when run alone. Mark it flaky so flakes don't fail CI. Ref: Unable to locate reference Co-Authored-By: Claude <[email protected]> (cherry picked from commit 3853529) (cherry picked from commit 2dfc1ae) * test: disable test-tls-set-default-ca-certificates-extra-override setDefaultCACertificates() round-trips the default CA set through BoringSSL's X509_STORE, which dedups a duplicate-subject root (DigiCert Global Root CA) that OpenSSL keeps. The set therefore loses one cert on re-add (149 -> 148), so the test's assertEqualCerts round-trip check fails under Electron's BoringSSL. The sibling -recovery test is disabled for the same reason. Ref: nodejs/node#58822 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 3dbc596) (cherry picked from commit 44f4094) * fix(patch): mark test-runner watch tests as flaky test-run-watch-repeatedly, test-run-watch-run-duration and test-run-watch-without-file race under parallel suite load: the watcher fires an extra re-run before the assertion, so the expected single-run output ("tests 1") arrives with accumulated subtests. All three pass in isolation. Ref: nodejs/node#44898 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 0f9c327) (cherry picked from commit 792e1e5) * chore(patches): update libuv const-cast patch management Combine the Windows libuv cpu_info const-cast update into the existing chore_cast_const_away_when_freeing_uv_cpu_info_t_model.patch and keep a single patch-management commit for the final exported patch series. Co-Authored-By: Claude <[email protected]> (cherry picked from commit c590614) (cherry picked from commit 0506b64) * fix(patch): add UV_LOOP_INTERRUPT_ON_IO_CHANGE option Ref: libuv/libuv#3308 Co-Authored-By: Claude <[email protected]> (cherry picked from commit 31b7fb0) * fix(patch): update GetIsolate removal for inspector NetworkAgent refactor Upstream refactored the inspector network agent helpers into NetworkAgent:: methods, shifting where context->GetIsolate() appeared and reorganizing node_contextify's PropertyDefinerCallback. Re-applied the deprecated context->GetIsolate() -> v8::Isolate::GetCurrent() replacements to the new structure. Ref: nodejs/node#62162 Co-Authored-By: Claude Opus 4.8 <[email protected]> * fix: drop dangling .patches entries for non-existent patch files The cherry-pick of the cast-const fix (343078bf01) erroneously added four entries to patches/node/.patches that reference patch files which were never part of the 41-x-y branch (externalpointertypetag, thinlto symbol preservation, v8 code cache, and startup snapshot generation). The missing files caused `e sync` to abort while reading patches. Co-Authored-By: Claude Opus 4.8 <[email protected]> * chore: update patches (trivial only) Co-Authored-By: Claude Opus 4.8 <[email protected]> * test: disable test-vm-global-contextual-store This new upstream test asserts that a strict-mode store to an undeclared global in a vm context throws ReferenceError. Chromium's V8 contextify global-proxy interceptor instead creates the property, so the assertion is fundamentally incompatible with Electron's V8 and cannot be guarded to pass. Ref: nodejs/node#62571 Co-Authored-By: Claude Opus 4.8 <[email protected]> --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Claude <[email protected]>

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 15, 2026

nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Feb 15, 2026

aduh95 approved these changes Feb 15, 2026

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 15, 2026

github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 15, 2026

cjihrig approved these changes Feb 15, 2026

View reviewed changes

lpinca approved these changes Feb 15, 2026

View reviewed changes

lpinca added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 15, 2026

santigimeno approved these changes Feb 15, 2026

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026

nodejs-github-bot force-pushed the actions/tools-update-libuv branch from 6a25a76 to 5915071 Compare February 22, 2026 00:49

nodejs-github-bot force-pushed the actions/tools-update-libuv branch from 5915071 to d240140 Compare March 1, 2026 00:54

deps: update libuv to 1.52.1

d282cbb

nodejs-github-bot changed the title ~~deps: update libuv to 1.52.0~~ deps: update libuv to 1.52.1 Mar 8, 2026

nodejs-github-bot force-pushed the actions/tools-update-libuv branch from d240140 to d282cbb Compare March 8, 2026 00:49

RafaelGSS approved these changes Mar 9, 2026

View reviewed changes

test: fix assert for libuv v1.52.1

3622960

aduh95 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 15, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2026

nodejs-github-bot merged commit 5bebd7e into main Mar 15, 2026
122 of 123 checks passed

nodejs-github-bot deleted the actions/tools-update-libuv branch March 15, 2026 23:46

RafaelGSS mentioned this pull request Apr 27, 2026

2026-05-05, Version 26.0.0 (Current) #62526

Merged

github-actions Bot mentioned this pull request May 12, 2026

2026-05-21, Version 24.16.0 'Krypton' (LTS) #63263

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: update libuv to 1.52.1#61829

deps: update libuv to 1.52.1#61829
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-libuv

nodejs-github-bot commented Feb 15, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Feb 15, 2026

Uh oh!

github-actions Bot commented Feb 15, 2026

Uh oh!

nodejs-github-bot commented Feb 18, 2026

Uh oh!

aduh95 commented Feb 18, 2026

Uh oh!

StefanStojanovic commented Feb 19, 2026

Uh oh!

StefanStojanovic commented Mar 2, 2026

Uh oh!

codecov Bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

aduh95 commented Mar 10, 2026

Uh oh!

StefanStojanovic commented Mar 10, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

nodejs-github-bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 15, 2026

Uh oh!

github-actions Bot commented Feb 15, 2026

Uh oh!

nodejs-github-bot commented Feb 18, 2026

Uh oh!

aduh95 commented Feb 18, 2026

Uh oh!

StefanStojanovic commented Feb 19, 2026

Uh oh!

StefanStojanovic commented Mar 2, 2026

Uh oh!

codecov Bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aduh95 commented Mar 10, 2026

Uh oh!

StefanStojanovic commented Mar 10, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nodejs-github-bot commented Feb 15, 2026 •

edited

Loading

codecov Bot commented Mar 9, 2026 •

edited

Loading