doc: clarify fs.copyFile() symlink behavior#61669
doc: clarify fs.copyFile() symlink behavior#61669junnyontop-pixel wants to merge 1 commit intonodejs:mainfrom
Conversation
|
Sorry, I accidentally included a README change from my main branch. I will fix this PR to only include fs.md changes. |
|
Please can you squash your commits, so that |
junnyontop-pixel
force-pushed
the
doc-copyfile-symlink
branch
2 times, most recently
from
43c94a9 to
d7f81cb
Compare
|
I've squashed the commits into one and fixed the trailing whitespace issue. The commit message has also been updated as you requested. Thanks! |
|
Hi @Renegade334, I've completed all the requested changes. Could you please take another look when you have a moment? Thanks! |
|
Sorry, I closed and reopened this PR by mistake. |
Renegade334
left a comment
Renegade334
left a comment
There was a problem hiding this comment.
Thanks, just needs a quick layout edit.
doc/api/fs.md
Outdated
| Note: `fs.copyFile()` always dereferences symbolic links. | ||
| If `src` is a symbolic link, the contents of the target file will be copied rather than the link itself. | ||
|
|
There was a problem hiding this comment.
Can you please move this to the main description body? It shouldn't be above the section header. In between the first and second paragraphs seems like a sensible place.
There was a problem hiding this comment.
I've moved the note to the suggested location. Thanks for the guidance!
junnyontop-pixel
force-pushed
the
doc-copyfile-symlink
branch
from
d7f81cb to
fc3c5ab
Compare
3 participants
This PR documents that
fs.copyFile()always dereferences symbolic links, as requested in #61518.When
srcis a symbolic link, the contents of the target file are copied instead of the link itself.Fixes: #61518