Skip to content

test: delay writing the files only on macOS #61532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jan 28, 2026
Merged

test: delay writing the files only on macOS #61532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: delay writing the files only on macOS 
Refs: #60060
  • Loading branch information
@lpinca
lpinca committed Jan 26, 2026
commit 489a2663d73ea5d7f21fa73a9784353cdf7fb218
7 changes: 5 additions & 2 deletions test/parallel/test-fs-promises-watch-iterator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,11 @@ class WatchTestCase {
}
}
async writeFiles() {
// Do the write with a delay to ensure that the OS is ready to notify us.
await setTimeout(common.platformTimeout(100));
if (common.isMacOS) {
// Do the write with a delay to ensure that the OS is ready to notify us.
// See https://github.com/nodejs/node/issues/52601.
await setTimeout(common.platformTimeout(100));
}

for (const fileName of [...this.files]) {
await writeFile(this.filePath(fileName), Date.now() + fileName.repeat(1e4));
Expand Down
Loading