Skip to content

lib: correct windows-1252 decoding in TextDecoder #60737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashwantbezawada wants to merge 3 commits into from
Closed

lib: correct windows-1252 decoding in TextDecoder #60737

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24a2207
lib: correct windows-1252 decoding in TextDecoder
yashwantbezawada Nov 15, 2025
515720d
lib: remove Latin-1 fast path from TextDecoder
yashwantbezawada Nov 16, 2025
de6c369
lib: remove unused decodeLatin1 import
yashwantbezawada Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: remove unused decodeLatin1 import 
Remove the decodeLatin1 import from encoding_binding as it is no longer
used after disabling the Latin-1 fast path for Windows-1252.
  • Loading branch information
@yashwantbezawada
yashwantbezawada committed Nov 26, 2025
commit de6c36924f61cb4772fd12e42b608f02cb3749f5
1 change: 0 additions & 1 deletion lib/internal/encoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ const {
encodeIntoResults,
encodeUtf8String,
decodeUTF8,
decodeLatin1,
} = binding;

const { Buffer } = require('buffer');
Expand Down
Loading