Skip to content

test: ensure assertions are reached on more tests #60641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Nov 11, 2025
Merged

test: ensure assertions are reached on more tests #60641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3524b52
test: ensure assertions are reached on more tests
aduh95 Nov 8, 2025
008eed0
fixup! test: ensure assertions are reached on more tests
aduh95 Nov 8, 2025
4a388f1
fixup! test: ensure assertions are reached on more tests
aduh95 Nov 8, 2025
ba929ad
fixup! fixup! test: ensure assertions are reached on more tests
aduh95 Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! test: ensure assertions are reached on more tests
  • Loading branch information
@aduh95
aduh95 committed Nov 8, 2025
commit 008eed0af2fc9e8f2c04f70e9ae57c8dbae23ee4
2 changes: 1 addition & 1 deletion test/parallel/test-diagnostics-channel-module-require.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const events = [];
let lastEvent;

function track(name) {
return common.mustCall((event) =>{
return common.mustCall((event) => {
// Verify every event after the first is the same object
if (events.length) {
assert.strictEqual(event, lastEvent);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-worker-arraybuffer-zerofill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@

w.on('online', fn);

const countdown = new Countdown(100, () => {
const countdown = new Countdown(100, common.mustCallAtLeast(() => {

Check failure on line 33 in test/parallel/test-worker-arraybuffer-zerofill.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

'common' is not defined
w.terminate();
assert(fn.mock.calls.length > 0);
});
}));

w.on('message', (sum) => {
assert.strictEqual(sum, 0);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-worker-message-port-transfer-self.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ port2.onmessage = common.mustCall((message) => {

port1.close();

tick(10, () => {
tick(10, common.mustCall(() => {
const inspectedPort1 = util.inspect(port1);
const inspectedPort2 = util.inspect(port2);
assert(inspectedPort1.includes('active: false'), inspectedPort1);
assert(inspectedPort2.includes('active: false'), inspectedPort2);
});
}, 10));
});
port1.postMessage(2);
Loading