Skip to content

test: refactor test-file-write-stream3 #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: refactor test-file-write-stream3 #6050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-file-write-stream3 
* use common.mustCall() to verify all tests have run
* eliminate unneeded removeTestFile()
* eliminate unneeded var leaking into global scope
* var -> const
* remove instance of let
  • Loading branch information
@Trott
Trott committed Apr 5, 2016
commit eb1d40d548b3f8f6e43b5b3ade0e3ec9a3cf1bae
31 changes: 9 additions & 22 deletions test/parallel/test-file-write-stream3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,20 @@ const path = require('path');
const fs = require('fs');


var filepath = path.join(common.tmpDir, 'write_pos.txt');
const filepath = path.join(common.tmpDir, 'write_pos.txt');


const cb_expected = 'write open close write open close write open close ';
let cb_occurred = '';
var cb_occurred = '';

var fileDataInitial = 'abcdefghijklmnopqrstuvwxyz';
const fileDataInitial = 'abcdefghijklmnopqrstuvwxyz';

var fileDataExpected_1 = 'abcdefghijklmnopqrstuvwxyz';
var fileDataExpected_2 = 'abcdefghij123456qrstuvwxyz';
var fileDataExpected_3 = 'abcdefghij\u2026\u2026qrstuvwxyz';
const fileDataExpected_1 = 'abcdefghijklmnopqrstuvwxyz';
const fileDataExpected_2 = 'abcdefghij123456qrstuvwxyz';
const fileDataExpected_3 = 'abcdefghij\u2026\u2026qrstuvwxyz';


process.on('exit', function() {
removeTestFile();
if (cb_occurred !== cb_expected) {
console.log(' Test callback events missing or out of order:');
console.log(' expected: %j', cb_expected);
Expand All @@ -30,12 +29,6 @@ process.on('exit', function() {
}
});

function removeTestFile() {
try {
fs.unlinkSync(filepath);
} catch (ex) { }
}


common.refreshTmpDir();

Expand Down Expand Up @@ -164,20 +157,14 @@ function run_test_3() {
}


function run_test_4() {
var options;

options = { start: -5,
flags: 'r+' };

const run_test_4 = common.mustCall(function() {
// Error: start must be >= zero
assert.throws(
function() {
file = fs.createWriteStream(filepath, options);
fs.createWriteStream(filepath, { start: -5, flags: 'r+' });
},
/"start" must be/
);

}
});

run_test_1();