Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
18db2af
buffer: faster case for create buffer from empty string
JacksonTian Dec 18, 2015
6e4d9b3
build: enable compilation for linuxOne
mhdawson Mar 28, 2016
f56d6ad
build: add missing `openssl_fips%` to common.gypi
indutny Mar 27, 2016
09dc4cc
build: add script to create Android .mk files
robertchiras Mar 3, 2016
882fa25
build: add suport for x86 architecture
robertchiras Mar 3, 2016
459a7d6
child_process: refactor self=this in socket_list
benjamingr Mar 23, 2016
37f4df4
deps: backport 8d00c2c from v8 upstream
bnoordhuis Mar 6, 2016
648e0c3
dns: Use object without protoype for map
benjamingr Mar 22, 2016
4916fff
dns: Refactor forEach to map
benjamingr Mar 22, 2016
715ba18
doc: fix doc for Buffer.readInt32LE()
ghaiklor Mar 24, 2016
0da59ef
doc: add instructions to only sign a release
Fishrock123 Mar 23, 2016
b9682af
doc: fix order of end tags of list after heading
Mar 3, 2016
fc6513d
doc: use consistent event name parameter
benjamingr Mar 22, 2016
93638e1
doc: explain path.format expected properties
eversojk Mar 19, 2016
9e5fe2b
doc: typo: interal->internal.
kosak Mar 22, 2016
8df627e
etw: fix descriptors of events 9 and 23
joaocgreis Mar 16, 2016
1490a45
fs: add the fs.mkdtemp() function.
ralt Feb 24, 2016
f275176
http: speed up checkIsHttpToken
JacksonTian Jan 21, 2016
1d4c751
zlib: Fix handling of gzip magic bytes mid-file
addaleax Mar 23, 2016
5b5cb7e
win,build: build and test add-ons on test-ci
Mar 24, 2016
dddd365
tools: fix json doc generation
firedfox Mar 29, 2016
cebb8d7
timers: fixing API refs to use safe internal refs
getify Aug 22, 2015
cc85dd7
test: fix test-debugger-client.js
Trott Mar 22, 2016
ee8de3f
test: fix flaky test-http-set-timeout
Trott Mar 23, 2016
42903cc
test: move dns test to test/internet
bnoordhuis Mar 25, 2016
25244c1
test: fix flaky test-net-socket-timeout
mscdex Mar 24, 2016
f616adb
test: confirm globals not used internally
Trott Mar 24, 2016
5dc8df2
test: exclude new fs watch test for AIX
mhdawson Mar 28, 2016
5822f47
test: remove the use of curl in the test suite
santigimeno Mar 16, 2016
b8415ad
test: add test for piping large input from stdin
addaleax Mar 29, 2016
3f6fbaf
src: override v8 thread defaults using cli options
tomgco Dec 18, 2015
58de768
repl: support standalone blocks
princejwesley Mar 7, 2016
6ea6b64
querystring: don't stringify bad surrogate pair
mscdex Mar 23, 2016
d1483f0
net: emit host in lookup event
entertainyou Mar 8, 2016
8982d09
deps: upgrade npm to 3.8.3
othiym23 Mar 30, 2016
a7710b0
lib: refactor code with startsWith/endsWith
JacksonTian Mar 17, 2016
8bd81b2
src: Add missing `using v8::MaybeLocal`
addaleax Mar 31, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: use consistent event name parameter
Implementing the suggestion in
#4554 this pull request renames
the parameter name in all the places that accept an event name as a parameter.

Previously, the parameter has been called `event` or `type`. Now as suggested
it is consistently called `eventName`.

PR-URL: #5850
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
  • Loading branch information
benjamingr authored and evanlucas committed Mar 30, 2016
commit fc6513d37516009a2e95db3258bc6c85b0a783fe
60 changes: 31 additions & 29 deletions doc/api/events.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ added and `'removeListener'` when a listener is removed.

### Event: 'newListener'

* `event` {String|Symbol} The event name
* `eventName` {String|Symbol} The name of the event being listened for
* `listener` {Function} The event handler function

The `EventEmitter` instance will emit it's own `'newListener'` event *before*
Expand Down Expand Up @@ -237,16 +237,16 @@ myEmitter.emit('event');

### Event: 'removeListener'

* `event` {String|Symbol} The event name
* `eventName` {String|Symbol} The event name
* `listener` {Function} The event handler function

The `'removeListener'` event is emitted *after* a listener is removed.

### EventEmitter.listenerCount(emitter, event)
### EventEmitter.listenerCount(emitter, eventName)

Stability: 0 - Deprecated: Use [`emitter.listenerCount()`][] instead.

A class method that returns the number of listeners for the given `event`
A class method that returns the number of listeners for the given `eventName`
registered on the given `emitter`.

```js
Expand Down Expand Up @@ -284,32 +284,33 @@ emitter.once('event', () => {
});
```

### emitter.addListener(event, listener)
### emitter.addListener(eventName, listener)

Alias for `emitter.on(event, listener)`.
Alias for `emitter.on(eventName, listener)`.

### emitter.emit(event[, arg1][, arg2][, ...])
### emitter.emit(eventName[, arg1][, arg2][, ...])

Synchronously calls each of the listeners registered for `event`, in the order
they were registered, passing the supplied arguments to each.
Synchronously calls each of the listeners registered for the event named
`eventName`, in the order they were registered, passing the supplied arguments
to each.

Returns `true` if event had listeners, `false` otherwise.
Returns `true` if the event had listeners, `false` otherwise.

### emitter.getMaxListeners()

Returns the current max listener value for the `EventEmitter` which is either
set by [`emitter.setMaxListeners(n)`][] or defaults to
[`EventEmitter.defaultMaxListeners`][].

### emitter.listenerCount(event)
### emitter.listenerCount(eventName)

* `event` {Value} The type of event
* `eventName` {Value} The name of the event being listened for

Returns the number of listeners listening to the `event` type.
Returns the number of listeners listening to the event named `eventName`.

### emitter.listeners(event)
### emitter.listeners(eventName)

Returns a copy of the array of listeners for the specified `event`.
Returns a copy of the array of listeners for the event named `eventName`.

```js
server.on('connection', (stream) => {
Expand All @@ -319,12 +320,12 @@ console.log(util.inspect(server.listeners('connection')));
// Prints: [ [Function] ]
```

### emitter.on(event, listener)
### emitter.on(eventName, listener)

Adds the `listener` function to the end of the listeners array for the
specified `event`. No checks are made to see if the `listener` has already
been added. Multiple calls passing the same combination of `event` and
`listener` will result in the `listener` being added, and called, multiple
event named `eventName`. No checks are made to see if the `listener` has
already been added. Multiple calls passing the same combination of `eventName`
and `listener` will result in the `listener` being added, and called, multiple
times.

```js
Expand All @@ -335,10 +336,11 @@ server.on('connection', (stream) => {

Returns a reference to the `EventEmitter` so calls can be chained.

### emitter.once(event, listener)
### emitter.once(eventName, listener)

Adds a **one time** `listener` function for the `event`. This listener is
invoked only the next time `event` is triggered, after which it is removed.
Adds a **one time** `listener` function for the event named `eventName`. This
listener is invoked only the next time `eventName` is triggered, after which
it is removed.

```js
server.once('connection', (stream) => {
Expand All @@ -348,20 +350,20 @@ server.once('connection', (stream) => {

Returns a reference to the `EventEmitter` so calls can be chained.

### emitter.removeAllListeners([event])
### emitter.removeAllListeners([eventName])

Removes all listeners, or those of the specified `event`.
Removes all listeners, or those of the specified `eventName`.

Note that it is bad practice to remove listeners added elsewhere in the code,
particularly when the `EventEmitter` instance was created by some other
component or module (e.g. sockets or file streams).

Returns a reference to the `EventEmitter` so calls can be chained.

### emitter.removeListener(event, listener)
### emitter.removeListener(eventName, listener)

Removes the specified `listener` from the listener array for the specified
`event`.
Removes the specified `listener` from the listener array for the event named
`eventName`.

```js
var callback = (stream) => {
Expand All @@ -374,8 +376,8 @@ server.removeListener('connection', callback);

`removeListener` will remove, at most, one instance of a listener from the
listener array. If any single listener has been added multiple times to the
listener array for the specified `event`, then `removeListener` must be called
multiple times to remove each instance.
listener array for the specified `eventName`, then `removeListener` must be
called multiple times to remove each instance.

Note that once an event has been emitted, all listeners attached to it at the
time of emitting will be called in order. This implies that any `removeListener()`
Expand Down