Skip to content

http: add optional logging for socket timeouts #59514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohit-chouhan wants to merge 8 commits into
base: main
Choose a base branch
from
+16 −0
Open

http: add optional logging for socket timeouts #59514

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
de3599c
http: add optional logging for socket timeouts
rohit-chouhan Aug 18, 2025
eb3a622
test: add coverage for HTTP socket timeout logging
rohit-chouhan Aug 18, 2025
7d974bf
http: add optional logging for socket timeouts
rohit-chouhan Aug 18, 2025
b0465de
test: add coverage for HTTP socket timeout logging
rohit-chouhan Aug 18, 2025
1ecbc78
http: add optional logging for socket timeouts
rohit-chouhan Aug 18, 2025
ec9a8f5
test: add coverage for HTTP socket timeout logging
rohit-chouhan Aug 18, 2025
974ed71
http: add optional logging for socket timeouts
rohit-chouhan Aug 18, 2025
1f5c256
test: add coverage for HTTP socket timeout logging
rohit-chouhan Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: add optional logging for socket timeouts
  • Loading branch information
@rohit-chouhan
rohit-chouhan authored Aug 18, 2025
commit 7d974bf2781e803bc3bc992d0f7cfa3e035cd559
8 changes: 4 additions & 4 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ const {
const net = require('net');
const EE = require('events');
const assert = require('internal/assert');
const util = require('internal/util');
const {
parsers,
freeParser,
Expand Down Expand Up @@ -811,10 +812,9 @@ function socketOnTimeout() {
const resTimeout = res && res.emit('timeout', this);
const serverTimeout = this.server.emit('timeout', this);

// Suggested addition: Optional debug logging
if (process.env.NODE_DEBUG_TIMEOUTS) {
console.log(`Socket timeout: req=${!!req}, res=${!!res}, server=${!!serverTimeout}`);
}
// Use util.debuglog for conditional logging
const debug = util.debuglog('http');
Copy link
Member

@mcollina mcollina Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to the top of the file

debug('Socket timeout: req=%s, res=%s, server=%s', !!req, !!res, !!serverTimeout);

if (!reqTimeout && !resTimeout && !serverTimeout)
this.destroy();
Expand Down