test: remove the use of curl in the test suite#5750
Closed
santigimeno wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove the use of curl in the test suite#5750santigimeno wants to merge 1 commit intonodejs:masterfrom
santigimeno wants to merge 1 commit intonodejs:masterfrom
Conversation
There were 2 tests using curl: `test-http-304.js` is removed because it was initially included to test that the 304 response does not contain a body, and this is already covered by `test-http-chunked-304.js`. `test-http-curl-chunk-problem` has been renamed and refactored so instead of using curl, it uses 2 child node processes: one for sending the HTTP request and the other to calculate the sha1sum. Originally, this test was introduced to fix a bug in `[email protected]`, and it was not fixed until `[email protected]`. A modified version of this test has been run with `[email protected]` and reproduces the problem. This same test has been run with `[email protected]` and runs correctly.
mscdex
added
test
Member
Author
|
It tries to fix #5174. |
Member
|
I'm a little hesitant to move forward with removing the explicit curl test from test-http-curl-chunk-problem but if what you say is correct that you can reproduce the problem with this new test case then (1) impressive work to go back so far and (2) I guess that's a positive sign that this is OK to move ahead, (although not definitive). /cc @jbergstroem @nodejs/testing thoughts? |
Member
|
LGTM. I'm fine with renaming test-http-curl-chunk-problem.js; it's poorly named because the real issue wasn't with curl but with node. |
Member
|
LGTM me too. If the curl test was specific to curl and not node it shouldn't have belong in our test suite anyway. |
Member
|
LGTM |
Member
Fishrock123
pushed a commit
that referenced
this pull request
Mar 29, 2016
There were 2 tests using curl: `test-http-304.js` is removed because it was initially included to test that the 304 response does not contain a body, and this is already covered by `test-http-chunked-304.js`. `test-http-curl-chunk-problem` has been renamed and refactored so instead of using curl, it uses 2 child node processes: one for sending the HTTP request and the other to calculate the sha1sum. Originally, this test was introduced to fix a bug in `[email protected]`, and it was not fixed until `[email protected]`. A modified version of this test has been run with `[email protected]` and reproduces the problem. This same test has been run with `[email protected]` and runs correctly. Fixes: #5174 PR-URL: #5750 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Contributor
|
Thanks, landed in 82fdaae! @santigimeno could you please set |
4 tasks
Member
Author
@Fishrock123 will do. Thanks |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
There were 2 tests using curl: `test-http-304.js` is removed because it was initially included to test that the 304 response does not contain a body, and this is already covered by `test-http-chunked-304.js`. `test-http-curl-chunk-problem` has been renamed and refactored so instead of using curl, it uses 2 child node processes: one for sending the HTTP request and the other to calculate the sha1sum. Originally, this test was introduced to fix a bug in `[email protected]`, and it was not fixed until `[email protected]`. A modified version of this test has been run with `[email protected]` and reproduces the problem. This same test has been run with `[email protected]` and runs correctly. Fixes: #5174 PR-URL: #5750 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Mar 30, 2016
There were 2 tests using curl: `test-http-304.js` is removed because it was initially included to test that the 304 response does not contain a body, and this is already covered by `test-http-chunked-304.js`. `test-http-curl-chunk-problem` has been renamed and refactored so instead of using curl, it uses 2 child node processes: one for sending the HTTP request and the other to calculate the sha1sum. Originally, this test was introduced to fix a bug in `[email protected]`, and it was not fixed until `[email protected]`. A modified version of this test has been run with `[email protected]` and reproduces the problem. This same test has been run with `[email protected]` and runs correctly. Fixes: #5174 PR-URL: #5750 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
There were 2 tests using curl: `test-http-304.js` is removed because it was initially included to test that the 304 response does not contain a body, and this is already covered by `test-http-chunked-304.js`. `test-http-curl-chunk-problem` has been renamed and refactored so instead of using curl, it uses 2 child node processes: one for sending the HTTP request and the other to calculate the sha1sum. Originally, this test was introduced to fix a bug in `[email protected]`, and it was not fixed until `[email protected]`. A modified version of this test has been run with `[email protected]` and reproduces the problem. This same test has been run with `[email protected]` and runs correctly. Fixes: #5174 PR-URL: #5750 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Mar 31, 2016
There were 2 tests using curl: `test-http-304.js` is removed because it was initially included to test that the 304 response does not contain a body, and this is already covered by `test-http-chunked-304.js`. `test-http-curl-chunk-problem` has been renamed and refactored so instead of using curl, it uses 2 child node processes: one for sending the HTTP request and the other to calculate the sha1sum. Originally, this test was introduced to fix a bug in `[email protected]`, and it was not fixed until `[email protected]`. A modified version of this test has been run with `[email protected]` and reproduces the problem. This same test has been run with `[email protected]` and runs correctly. Fixes: #5174 PR-URL: #5750 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test
Description of change
There were 2 tests using curl:
test-http-304.jsis removed because it was initially included to testthat the 304 response does not contain a body, and this is already
covered by
test-http-chunked-304.js.test-http-curl-chunk-problemhas been refactored so instead of usingcurl, it uses 2 child node processes: one for sending the HTTP request
and the other to calculate the sha1sum. Originally, this test was
introduced to fix a bug in
[email protected], and it was not fixed until[email protected]. A modified version of this test has been run with[email protected]and reproduces the problem. This same test has been runwith
[email protected]and runs correctly.