deps: remove unused openssl files#5619
Conversation
|
Do we want to document this? LGTM |
|
They're detritus from before we had a real process for upgrading openssl, if I understand your question right. |
|
they don't come from openssl source? |
|
Ah, ok then. |
|
OK, I've moved dist-indexer to try So this change lgtm |
|
These files are also included in openssl-1.0.2g.tar.gz but not in git repo. They are generated by |
|
LGTM |
1 similar comment
|
LGTM |
Refs: nodejs#5615 PR-URL: nodejs#5619 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
bnoordhuis
force-pushed
the
remove-unused-openssl-files
branch
from
0e8d5b1 to
a76cb4d
Compare
|
@bnoordhuis ... if I'm not mistaken this should be done in v4 also, correct? |
Refs: #5615 PR-URL: #5619 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
@jasnell Sorry, yes; forgot to add the label. I think the PR should apply cleanly. |
Refs: #5615 PR-URL: #5619 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Refs: #5615 PR-URL: #5619 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
8 participants
See #5615.
R=@nodejs/crypto @rvagg
CI: https://ci.nodejs.org/job/node-test-pull-request/1886/