Skip to content

doc: add check for security reverts#51376

Closed
mhdawson wants to merge 3 commits intonodejs:mainfrom
mhdawson:security-process-update
Closed

doc: add check for security reverts#51376
mhdawson wants to merge 3 commits intonodejs:mainfrom
mhdawson:security-process-update

Conversation

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jan 4, 2024

  • Add step to check that any PRs with breaking changes have command line options to revert
  • Add info on how to easily add command line option to revert a breaking change related to a CVE

@mhdawson
doc: add check for security reverts
d1c2716 
- Add step to check that any PRs with breaking changes
  have command line options to revert
- Add info on how to easily add command line option
  to revert a breaking change related to a CVE

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 4, 2024

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 4, 2024
aduh95
aduh95 reviewed Jan 5, 2024
View reviewed changes
bnb
bnb reviewed Jan 5, 2024
View reviewed changes
doc/contributing/security-release-process.md Outdated
Comment on lines 230 to 236
Copy link
Contributor

@bnb bnb Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This starts by talking about LTS lines, but then switches context to Node.js includes. Upon first read, I assumed that this flag would only be included in LTS versions, missing the context switch. I'd recommend adding more, direct language about where and when this feature is available.

mhdawson added a commit that referenced this pull request Jan 8, 2024
@mhdawson
doc: add check for security reverts
718e4e6 
- Add step to check that any PRs with breaking changes
  have command line options to revert
- Add info on how to easily add command line option
  to revert a breaking change related to a CVE

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #51376
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented Jan 8, 2024

Landed in 718e4e6

@mhdawson mhdawson closed this Jan 8, 2024
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@mhdawson @marco-ippolito
doc: add check for security reverts
ea10bee 
- Add step to check that any PRs with breaking changes
  have command line options to revert
- Add info on how to easily add command line option
  to revert a breaking change related to a CVE

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#51376
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@mhdawson @Medhansh404
doc: add check for security reverts
6bb3074 
- Add step to check that any PRs with breaking changes
  have command line options to revert
- Add info on how to easily add command line option
  to revert a breaking change related to a CVE

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#51376
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
@mhdawson @targos
doc: add check for security reverts
70e88cf 
- Add step to check that any PRs with breaking changes
  have command line options to revert
- Add info on how to easily add command line option
  to revert a breaking change related to a CVE

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #51376
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@mhdawson @richardlau
doc: add check for security reverts
2de1c85 
- Add step to check that any PRs with breaking changes
  have command line options to revert
- Add info on how to easily add command line option
  to revert a breaking change related to a CVE

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #51376
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@mhdawson @richardlau
doc: add check for security reverts
a09f440 
- Add step to check that any PRs with breaking changes
  have command line options to revert
- Add info on how to easily add command line option
  to revert a breaking change related to a CVE

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #51376
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb left review comments

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mhdawson @nodejs-github-bot @bnb @lpinca @tniessen @gireeshpunathil @aduh95 @RafaelGSS

Comments