Skip to content

module: load source maps in commonjs translator #51053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
privatenumber wants to merge 3 commits into from
Closed

module: load source maps in commonjs translator #51053

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b43f701
module: load source maps in commonjs translator
privatenumber Dec 3, 2023
4823151
Merge branch 'main' into 50649
privatenumber Dec 5, 2023
4cfe895
module: verbose variable names in tests
privatenumber Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
module: verbose variable names in tests
  • Loading branch information
@privatenumber
privatenumber committed Dec 5, 2023
commit 4cfe895a7e084492433014da53fdaccf021dacf4
38 changes: 19 additions & 19 deletions test/es-module/test-esm-loader-hooks.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,15 +726,15 @@ describe('Loader hooks', { concurrency: true }, () => {
'--no-warnings',
'--experimental-loader',
`data:text/javascript,import{readFile}from"node:fs/promises";import{fileURLToPath}from"node:url";export ${
async function load(u, c, n) {
const r = await n(u, c);
if (u.endsWith('/common/index.js')) {
r.source = '"use strict";module.exports=require("node:module").createRequire(' +
`${JSON.stringify(u)})(${JSON.stringify(fileURLToPath(u))});\n`;
} else if (c.format === 'commonjs') {
r.source = await readFile(new URL(u));
async function load(url, context, nextLoad) {
const resolved = await nextLoad(url, context);
if (url.endsWith('/common/index.js')) {
resolved.source = '"use strict";module.exports=require("node:module").createRequire(' +
`${JSON.stringify(url)})(${JSON.stringify(fileURLToPath(url))});\n`;
} else if (context.format === 'commonjs') {
resolved.source = await readFile(new URL(url));
}
return r;
return resolved;
}}`,
'--experimental-loader',
fixtures.fileURL('es-module-loaders/loader-resolve-passthru.mjs'),
Expand All @@ -754,12 +754,12 @@ describe('Loader hooks', { concurrency: true }, () => {
'--enable-source-maps',
'--experimental-loader',
`data:text/javascript,import{readFile}from"node:fs/promises";export ${
async function load(u, c, n) {
const r = await n(u, c);
if (c.format === 'commonjs') {
r.source = await readFile(new URL(u));
async function load(url, context, nextLoad) {
const resolved = await nextLoad(url, context);
if (context.format === 'commonjs') {
resolved.source = await readFile(new URL(url));
}
return r;
return resolved;
}}`,
fixtures.path('source-map/throw-on-require.js'),
]);
Expand All @@ -775,26 +775,26 @@ describe('Loader hooks', { concurrency: true }, () => {
'--no-warnings',
'--experimental-loader',
`data:text/javascript,const fixtures=${JSON.stringify(fixtures.path('empty.js'))};export ${
encodeURIComponent(function resolve(s, c, n) {
if (s.endsWith('entry-point')) {
encodeURIComponent(function resolve(specifier, context, nextResolve) {
if (specifier.endsWith('entry-point')) {
return {
shortCircuit: true,
url: 'file:///c:/virtual-entry-point',
format: 'commonjs',
};
}
return n(s, c);
return nextResolve(specifier, context);
})
}export ${
encodeURIComponent(async function load(u, c, n) {
if (u === 'file:///c:/virtual-entry-point') {
encodeURIComponent(async function load(url, context, nextLoad) {
if (url === 'file:///c:/virtual-entry-point') {
return {
shortCircuit: true,
source: `"use strict";require(${JSON.stringify(fixtures)});console.log("Hello");`,
format: 'commonjs',
};
}
return n(u, c);
return nextLoad(url, context);
})}`,
'entry-point',
]);
Expand Down