test: set dns-resolveany-bad-ancount timeout#50995
Closed
kapouer wants to merge 3 commits intonodejs:mainfrom
Closed
test: set dns-resolveany-bad-ancount timeout#50995kapouer wants to merge 3 commits intonodejs:mainfrom
kapouer wants to merge 3 commits intonodejs:mainfrom
Conversation
Some build environments just hang forever
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Dec 1, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
Author
|
Those changes don't make any sense, the server should respond right away in that test. |
Member
Contributor
Author
|
Yes, but setting the timeout as in this PR does not work at all. |
Member
|
The only problem I actually see in this PR is the You might also wonder why setting a timeout is required. The default one is two seconds. The problem is that after c-ares/c-ares@3b10e57 using -1 for the default timeout no longer works. As per our documentation we pass -1 but that is casted to an unsigned int (4294967295). This is an issue we should address before updating c-ares to version >= 1.21.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some build environments just hang forever.