node: deprecate process.EventEmitter#5049
Conversation
|
/cc @ChALkeR Does anyone use this anywhere? |
|
FWIW here is a github search for it as well. https://github.com/search?p=2&q=process.EventEmitter&type=Code&utf8=%E2%9C%93 |
|
LGTM |
1 similar comment
|
LGTM |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/1524/ Was the decision that we could deprecate in a minor version, or did we go with major? |
|
@mscdex This is used, though the usage is not high. Will post a list a bit later today. |
|
LGTM |
1 similar comment
|
LGTM |
|
@evanlucas you can get better results by quoting. |
|
oh nice |
|
https://gist.github.com/ChALkeR/232fdf64be9c34c9c733, sorted by downloads count per month. I'm +1 for deprecating this, but in a |
ChALkeR
added
the
semver-major
|
Major works for me |
|
LGTM, looks to be low-impact. |
|
CI https://ci.nodejs.org/job/node-test-pull-request/1550/ one more time before landing since the last one was red. |
The comment stating it was deprecated was added in 2011 via 4ef8f06. It is time to actually deprecate it. PR-URL: nodejs#5049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
|
Landed in 25751be. Thanks |
The comment stating it was deprecated was added in 2011 via 4ef8f06. It is time to actually deprecate it. PR-URL: nodejs#5049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
process.EventEmitter was deprecated for v6. This commit removes it for v7. Refs: #5049 PR-URL: #6862 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
9 participants
The comment stating it was deprecated was added in 2011 via
4ef8f06. It is time to actually deprecate it.