Skip to content

perf_hooks: reducing overhead of performance observer entry list #50008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Oct 4, 2023
Merged

perf_hooks: reducing overhead of performance observer entry list #50008

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
402067a
perf_hooks: reducing overhead of performance observer entry list
H4ad Oct 2, 2023
72b0d05
fixup! perf_hooks: reducing overhead of performance observer entry list
H4ad Oct 2, 2023
8a2a533
fixup! perf_hooks: reducing overhead of performance observer entry list
H4ad Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! perf_hooks: reducing overhead of performance observer entry list
  • Loading branch information
@H4ad
H4ad committed Oct 2, 2023
commit 8a2a5337483a00ba85b46bebe7bd06993cb3d594
9 changes: 3 additions & 6 deletions lib/internal/perf/observe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,6 @@ ObjectDefineProperties(PerformanceObserverEntryList.prototype, {
},
});

function createPerformanceObserverEntryList(entries) {
return new PerformanceObserverEntryList(kSkipThrow, entries);
}

class PerformanceObserver {
#buffer = [];
#entryTypes = new SafeSet();
Expand Down Expand Up @@ -353,8 +349,9 @@ class PerformanceObserver {
}

[kDispatch]() {
this.#callback(createPerformanceObserverEntryList(this.takeRecords()),
this);
const entryList = new PerformanceObserverEntryList(kSkipThrow, this.takeRecords());

this.#callback(entryList, this);
}

[kInspect](depth, options) {
Expand Down