Skip to content

fs: improve error performance of chownSync #49748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anonrig wants to merge 3 commits into from
Closed

fs: improve error performance of chownSync #49748

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a38a542
fs: improve error performance of `chownSync`
anonrig Sep 21, 2023
8437da5
fixup! fs: improve error performance of `chownSync`
anonrig Sep 21, 2023
d1ed9ff
fixup! fixup! fs: improve error performance of `chownSync`
anonrig Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fs: improve error performance of chownSync
  • Loading branch information
@anonrig
anonrig committed Sep 26, 2023
commit 8437da55be83814a1af15fab1c38dab663bf7743
5 changes: 5 additions & 0 deletions benchmark/fs/bench-chownSync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ const fs = require('fs');
const tmpdir = require('../../test/common/tmpdir');
tmpdir.refresh();

// Windows does not have `getuid` or `getgid`.
if (process.platform === 'win32') {
return;
}

const tmpfile = tmpdir.resolve(`.existing-file-${process.pid}`);
fs.writeFileSync(tmpfile, 'this-is-for-a-benchmark', 'utf8');

Expand Down
2 changes: 1 addition & 1 deletion src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2768,7 +2768,7 @@ static void ChownSync(const FunctionCallbackInfo<Value>& args) {
const uv_gid_t gid = static_cast<uv_gid_t>(args[2].As<Integer>()->Value());

uv_fs_t req;
auto make = OnScopeLeave([&req]() { uv_fs_req_cleanup(&req); });
auto cleanup = OnScopeLeave([&req]() { uv_fs_req_cleanup(&req); });
FS_SYNC_TRACE_BEGIN(chown);
int err = uv_fs_chown(nullptr, &req, *path, uid, gid, nullptr);
FS_SYNC_TRACE_END(chown);
Expand Down