lib: fix internalBinding typings#49742
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Sep 23, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Member
GeoffreyBooth
left a comment
GeoffreyBooth
left a comment
There was a problem hiding this comment.
This is amazing, thank you! Can you confirm that this fixes the references to ModuleWrap in the modules code? And/or update those references in this PR?
atlowChemi
approved these changes
Sep 20, 2023
Co-authored-by: Geoffrey Booth <[email protected]>
GeoffreyBooth
approved these changes
Sep 20, 2023
MoLow
approved these changes
Sep 21, 2023
anonrig
added
author ready
Ethan-Arrowood
approved these changes
Sep 21, 2023
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49742 ✔ Done loading data for nodejs/node/pull/49742 ----------------------------------- PR info ------------------------------------ Title lib: fix `internalBinding` typings (#49742) Author Yagiz Nizipli (@anonrig) Branch anonrig:internal-binding-2023 -> nodejs:main Labels lib / src, author ready, needs-ci, typings, commit-queue-squash Commits 2 - lib: fix `internalBinding` typings - Update globals.d.ts Committers 2 - Yagiz Nizipli - GitHub PR-URL: https://github.com/nodejs/node/pull/49742 Reviewed-By: Chemi Atlow Reviewed-By: Geoffrey Booth Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49742 Reviewed-By: Chemi Atlow Reviewed-By: Geoffrey Booth Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 20 Sep 2023 21:55:40 GMT ✔ Approvals: 4 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636575033 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636593235 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636652931 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636923558 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6279502512 |
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in da7962f |
20 tasks
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49742 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Closed
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49742 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've finally found a way to fix the
internalBindingtypings for both VSCode and Clion (Intellij).