Skip to content

esm: require braces for modules code #49657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Sep 15, 2023
Merged

esm: require braces for modules code #49657

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a1b3ee
esm: require braces for modules code
GeoffreyBooth Sep 14, 2023
024a2c1
Add missing braces
GeoffreyBooth Sep 6, 2023
a9a976e
Apply suggestions from code review
aduh95 Sep 15, 2023
17b4d98
fix lint
aduh95 Sep 15, 2023
9e3e794
fix tests
aduh95 Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
esm: require braces for modules code
  • Loading branch information
@GeoffreyBooth @aduh95
GeoffreyBooth authored and aduh95 committed Sep 15, 2023
commit 0a1b3ee9c6fbc79e768fda343acc855267a0c3e3
12 changes: 10 additions & 2 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ module.exports = {
overrides: [
{
files: [
'test/es-module/test-esm-type-flag.js',
'test/es-module/test-esm-type-flag-alias.js',
'*.mjs',
'test/es-module/test-esm-example-loader.js',
'test/es-module/test-esm-type-flag.js',
'test/es-module/test-esm-type-flag-alias.js',
],
parserOptions: { sourceType: 'module' },
},
Expand Down Expand Up @@ -111,6 +111,14 @@ module.exports = {
},
] },
},
{
files: [
'lib/internal/modules/**/*.js',
],
rules: {
'curly': 'error',
},
},
{
files: [
'lib/internal/test_runner/**/*.js',
Expand Down